Uh oh!
There was an error while loading. Please reload this page.
Wrap transaction with new struct to include ISRs - #885
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@## main #885 +/- ##
==========================================
- Coverage 55.91% 54.60% -1.32%
==========================================
Files 66 66 Lines 10709 10959 +250 ==========================================
- Hits 5988 5984 -4 - Misses 3849 4105 +256 + Partials 872 870 -2
☔ View full report in Codecov by Sentry. |
gupadhyaya
commented
Apr 25, 2023
@Manav-Aggarwal can you rebase with main again? looks like it is showing lots of changes from your previous PR. |
8206833 to
7d77219CompareManav-Aggarwal
commented
Apr 25, 2023
done |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
nashqueue
left a comment
There was a problem hiding this comment.
Thank you ! 1 nit 1 comment and a question.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
gupadhyaya
commented
Apr 28, 2023
ignore the CI/CD data race failure, as i am working on resolving it. for math/rand to crypto/rand, you can make the changes. |
Manav-Aggarwal
commented
Apr 28, 2023
Created issue for it here: #911 |
Closes: #880