Skip to content

Copy share package into Rollkit - #888

Merged
nashqueue merged 8 commits into
mainfrom
manav/add_share_pkg
Apr 24, 2023
Merged

Copy share package into Rollkit#888
nashqueue merged 8 commits into
mainfrom
manav/add_share_pkg

Conversation

@Manav-Aggarwal

@Manav-AggarwalManav-Aggarwal commented Apr 21, 2023

Copy link
Copy Markdown
Member

Closes: #887

Copy parts of share package relating to compact shares. We plan to later extract common code into a separate repo that both celestia-app and rollkit can use.

Changes needed to this code for use in rollkit will be handled in a later PR.

Also, extracts parts needed to resolve dependencies, specifically, namespace, appconsts, and `testfactory.

@Manav-AggarwalManav-Aggarwal self-assigned this Apr 21, 2023
@Manav-AggarwalManav-Aggarwal linked an issue Apr 21, 2023 that may be closed by this pull request
@Manav-AggarwalManav-Aggarwal changed the title Copy shares pkg inCopy share package into RollkitApr 21, 2023
@codecov

codecovBot commented Apr 21, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 69.28% and project coverage change: +0.92 🎉

Comparison is base (acf0090) 55.17% compared to head (85671ec) 56.09%.

Additional details and impacted files
@@ Coverage Diff @@## main #888 +/- ##
==========================================
+ Coverage 55.17% 56.09% +0.92% 
==========================================
Files 54 66 +12 Lines 9985 10698 +713 ==========================================
+ Hits 5509 6001 +492 - Misses 3656 3829 +173 - Partials 820 868 +48 
Impacted FilesCoverage Δ
libs/namespace/random_namespace.go0.00% <0.00%> (ø)
libs/namespace/random_blob.go53.33% <53.33%> (ø)
libs/shares/shares.go53.90% <53.90%> (ø)
libs/shares/parse_compact_shares.go64.00% <64.00%> (ø)
libs/shares/split_compact_shares.go66.66% <66.66%> (ø)
libs/namespace/namespace.go67.14% <67.14%> (ø)
libs/shares/utils.go73.91% <73.91%> (ø)
libs/shares/share_builder.go76.31% <76.31%> (ø)
libs/testfactory/txs.go88.88% <88.88%> (ø)
libs/shares/share_sequence.go93.47% <93.47%> (ø)
... and 2 more

... and 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Manav-Aggarwal
Manav-Aggarwal marked this pull request as ready for review April 21, 2023 21:36
nashqueue
nashqueue previously approved these changes Apr 24, 2023

@nashqueuenashqueue left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve, as this is just a copy-paste from core and will be extracted later. :shipit:

@tzdybaltzdybal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about putting this new code into a subdirectory? For example libs/shares or just libs/ or something? I think this will make things cleaner and will make planned extraction easier.

@nashqueue
nashqueue merged commit c788fb1 into mainApr 24, 2023
@nashqueue
nashqueue deleted the manav/add_share_pkg branch April 24, 2023 19:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Copy share package into Rollkit

4 participants

@Manav-Aggarwal@tzdybal@gupadhyaya@nashqueue