fraud proof processing using go-fraud package

[gupadhyaya]

Update existing fraud proof processing logic to use ProofService from go-fraud package. Also, removes the old fraud proof gossip logic.

Fixes#895 & #945

[codecov]

Codecov Report

Patch coverage: 66.27% and project coverage change: +0.92 🎉

Comparison is base (c769503) 55.28% compared to head (c6f1ac3) 56.21%.

Additional details and impacted files

@@ Coverage Diff @@## main #928 +/- ##
==========================================
+ Coverage 55.28% 56.21% +0.92% 
==========================================
Files 68 68 Lines 10954 10940 -14 ==========================================
+ Hits 6056 6150 +94 + Misses 4017 3906 -111 - Partials 881 884 +3 

Impacted Files	Coverage Δ
p2p/client.go	60.08% <ø> (+<0.01%)	⬆️
types/header.go	28.88% <ø> (-10.40%)	⬇️
node/light.go	48.59% <32.14%> (+1.34%)	⬆️
state/executor.go	70.38% <40.00%> (+5.93%)	⬆️
block/manager.go	70.02% <85.10%> (+5.27%)	⬆️
node/full.go	68.57% <100.00%> (+6.70%)	⬆️
node/proof_service_factory.go	100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[Manav-Aggarwal]

Please fix failing CI/CD tests. For example, TestTxGossipingAndAggregation fails in this PR. Converted back to draft for now.

[Manav-Aggarwal]

Looks good, left some comments, mostly related to refactoring/consolidation of code.

[Manav-Aggarwal]

Thanks for addressing the comments! Currently, the fraud-proof generating full node proceeds to verify the fraud-proof it generates. Can we avoid that so that after generating a fraud-proof, the full node stops (previously was done in fraudProofPublishLoop)?

[gupadhyaya]

fraudProofPublishLoop

functionality wise, the full node after generating the fraud proof will not sync any further blocks (since SyncLoop returns) and ProcessFraudProof loop eventually cancels the context. I agree that the process might not be fully stopped, but this can be fixed by simply catching the context cancel call and stopping the node gracefully.

i tried to cancel the context upon receiving ErrFraudProofGenerated in the SyncLoop, however this prevented from fraud Broadcast to fully succeed (fraud didn't get gossiped). Hence, I am not sure if there is a better place (or way) to do this. However, created an issue for it: #947

[gupadhyaya]

fraudProofPublishLoop

functionality wise, the full node after generating the fraud proof will not sync any further blocks (since SyncLoop returns) and ProcessFraudProof loop eventually cancels the context. I agree that the process might not be fully stopped, but this can be fixed by simply catching the context cancel call and stopping the node gracefully.

i tried to cancel the context upon receiving ErrFraudProofGenerated in the SyncLoop, however this prevented from fraud Broadcast to fully succeed (fraud didn't get gossiped). Hence, I am not sure if there is a better place (or way) to do this. However, created an issue for it: #947

@Wondertan any suggestions for this? ideally, we want full nodes to broadcast the fraud proof and gracefully shutdown. However, currently canceling the context stops the broadcast for some reason.