Uh oh!
There was an error while loading. Please reload this page.
Clear Variant in DispatchComMethod.invoke before returning - #4
Merged
Conversation
The returned Variant can contain an IDispatch/IUnknown, and leaving that to be cleared by the GC sometime later can cause issues if that doesn't happen on the correct thread. Unlike COM wrapper objects, the Variant's finalizer doesn't schedule the actual clearing on the COM thread. Instead clearing just happens whenever the object is finalized, which can be on the wrong thread. The invoke method is already running on the correct COM thread and so the safest fix is to simply clear the variant before returning. Fixeskohsuke#91
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The returned Variant can contain an IDispatch/IUnknown, and leaving that to be cleared by the GC sometime later can cause issues if that doesn't happen on the correct thread.
Unlike COM wrapper objects, the Variant's finalizer doesn't schedule the actual clearing on the COM thread. Instead clearing just happens whenever the object is finalized, which can be on the wrong thread.
The invoke method is already running on the correct COM thread and so the safest fix is to simply clear the variant before returning.
Fixeskohsuke#91