Skip to content

Align MCP server with the 2026-07-28 specification - #2454

Merged
ejsmith merged 10 commits into
mainfrom
issue/mcp-2026-07-28-conformance
Aug 15, 2026
Merged

Align MCP server with the 2026-07-28 specification#2454
ejsmith merged 10 commits into
mainfrom
issue/mcp-2026-07-28-conformance

Conversation

@ejsmith

@ejsmithejsmith commented Aug 10, 2026

Copy link
Copy Markdown
Member

Summary

  • validate MCP Streamable HTTP Origin headers against the configured public and deployed origins
  • tighten Client ID Metadata Document validation and HTTP cache handling
  • align OAuth metadata, challenges, scopes, and authorization responses with the 2026-07-28 MCP specification
  • preserve Exie's structured MCP tool errors and add wire-level coverage
  • update the OpenAPI snapshot and generated Svelte API types

Why

This aligns the MCP and OAuth implementation with the 2026-07-28 specification while preserving down-level protocol support and the MCP server delivered in #2430.

Impact

Invalid browser origins are rejected with HTTP 403 on /mcp, while requests without an Origin header and requests from configured application/API origins continue normally. OAuth clients receive the required resource scope and issuer metadata. No public API or configuration keys are removed.

Verification

  • Release backend build: 0 warnings, 0 errors
  • MCP Origin middleware tests: 9 passed
  • OAuth client metadata/cache tests: 12 passed
  • OAuth/MCP integration tests: 71 passed
  • OpenAPI snapshot tests: 4 passed
  • Helm lint: production and development values passed
  • Helm render: all configured production and development MCP origins verified
  • Svelte npm run check: 0 errors, 0 warnings
  • git diff --check: passed

Breaking changes

None.

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:6be7f66af1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadsrc/Exceptionless.Core/Services/OAuthService.cs Outdated
Comment threadsrc/Exceptionless.Core/Services/OAuthClientMetadataService.cs Outdated

@niemyjskiniemyjski left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just missing act assert arrange on tests for consistency.

@niemyjski

Copy link
Copy Markdown
Member

Addressed the remaining review feedback in 6a530e6e3: the newly introduced tests now use explicit Arrange/Act/Assert sections, offline_access remains discoverable for MCP clients, and shared metadata caching honors s-maxage. Post-push build succeeds with 0 warnings/errors; focused metadata tests pass 9/9 and the protected-resource metadata endpoint test passes.

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:6a530e6e30

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadsrc/Exceptionless.Web/Api/Handlers/OAuthHandler.cs

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:839d416bb1

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadsrc/Exceptionless.Core/Services/OAuthClientMetadataService.cs Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:f4dfa9deac

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadsrc/Exceptionless.Web/Mcp/McpOriginValidationMiddleware.cs Outdated

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:cc1231e2f9

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadsrc/Exceptionless.Web/Mcp/McpOriginValidationMiddleware.cs Outdated
Base automatically changed from feature/exie-assistant to mainAugust 15, 2026 21:31

@chatgpt-codex-connectorchatgpt-codex-connectorBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:53b5e38d6f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment threadsrc/Exceptionless.Core/Services/OAuthClientMetadataService.cs Outdated
@github-actions

Copy link
Copy Markdown

Code Coverage

PackageLine RateBranch RateComplexityHealth
Exceptionless.Insulation37%35%286
Exceptionless.Core75%67%10164
Exceptionless.Web85%69%8089
Exceptionless.AppHost38%41%147
Summary78% (25184 / 32186)67% (11900 / 17726)18686

@ejsmith
ejsmith merged commit 6fb615b into mainAug 15, 2026
12 checks passed
@ejsmith
ejsmith deleted the issue/mcp-2026-07-28-conformance branch August 15, 2026 22:11
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ejsmith@niemyjski