Skip to content

🐛 FIX: i18n of buttons - #175

Closed
TheTripleV wants to merge 1 commit into
executablebooks:mainfrom
TheTripleV:patch-1
Closed

🐛 FIX: i18n of buttons#175
TheTripleV wants to merge 1 commit into
executablebooks:mainfrom
TheTripleV:patch-1

Conversation

@TheTripleV

@TheTripleVTheTripleV commented Dec 29, 2023•
edited
Loading

Copy link
Copy Markdown

@welcome

welcomeBot commented Dec 29, 2023

Copy link
Copy Markdown

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out EBP's Code of Conduct and our Contributing Guide, as this will greatly help the review process.

Welcome to the EBP community! 🎉

TheTripleV
TheTripleV commented Dec 29, 2023
View reviewed changes
Comment threadsphinx_design/badges_buttons.py
@TheTripleVTheTripleV changed the title Fix i18n of buttons🐛 FIX: i18n of buttonsDec 30, 2023
@TheTripleV
TheTripleV marked this pull request as draft December 30, 2023 02:44
@TheTripleV

TheTripleV commented Dec 30, 2023

Copy link
Copy Markdown
Author
Screenshot 2023-12-29 at 6 45 09 PM I fixed translations but broke button links somehow.

@larsonerlarsoner mentioned this pull request Nov 5, 2024
Closed
@sneakers-the-ratsneakers-the-rat mentioned this pull request May 19, 2026
Open
@chrisjsewellchrisjsewell mentioned this pull request Jul 12, 2026
Open
25 tasks
@chrisjsewellClaude

chrisjsewell commented Jul 12, 2026

Copy link
Copy Markdown
Member

Thanks @TheTripleV for digging into this back in 2023 — you had the right diagnosis (gettext targeting the whole directive rather than the button text) well before anyone else picked it up. Closing in favour of #264, which takes the same direction and adds .pot regression testing; the plan to land it (plus translated-build tests for button-ref) is tracked in #265. Your repro links from frc-docs-translations were genuinely useful in confirming the root cause. 🙏

Generated by Claude Code

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

internationalization is not working for buttons i18n: translating button-ref label results in loss of CSS classes

2 participants

@TheTripleV@chrisjsewell