') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); 🐛 Keep target anchors rendered in tab-set and tab-set-code by chrisjsewell · Pull Request #275 · executablebooks/sphinx-design · GitHub
Skip to content

🐛 Keep target anchors rendered in tab-set and tab-set-code - #275

Merged
chrisjsewell merged 1 commit into
mainfrom
brief/07-target-anchors
Jul 12, 2026
Merged

🐛 Keep target anchors rendered in tab-set and tab-set-code#275
chrisjsewell merged 1 commit into
mainfrom
brief/07-target-anchors

Conversation

@chrisjsewell

@chrisjsewellchrisjsewell commented Jul 12, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Follow-up fixing two bugs found in a retrospective review of #271 (which preserved target nodes but not their anchors):

  1. tab-set: docutils PropagateTargets moves a preceding target's ids onto the tab-item container, which TabSetHtmlTransform destroys (it only copied the rubric's ids) — so href="#my-target" pointed at nothing in HTML. The container's ids are now carried onto the rendered label.
  2. tab-set-code: targets were dropped entirely (asymmetric with tab-set), same broken-anchor result with no diagnostics. They are now preserved identically.

The #271 test passed against the broken output because it asserted target-node survival and refid resolution, but never that any rendered node still carries the id — it now asserts both that and the literal id="…" in the built HTML (verified to fail against unfixed code), plus a new tab-set-code variant.

Also includes the review's docs nit: get_started.md now says the extra MyST extensions need to be added to the myst_enable_extensions snippet shown, rather than implying the snippet already enables them.

Note: the py311-no-myst env fails on this branch's base due to #271's unguarded myst-parametrized tests — that fix is in #274; after it merges this branch rebases cleanly (mid-file edits only).

Validation: tox -e py311, mypy, ruff check/format, docs-furo all green; the strengthened tests confirmed red against unfixed tabs.py.

@codecov

codecovBot commented Jul 12, 2026•
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.08%. Comparing base (70cf79b) to head (dd64f37).

Additional details and impacted files
@@ Coverage Diff @@## main #275 +/- ##
==========================================
+ Coverage 89.95% 90.08% +0.12% 
==========================================
Files 12 12 Lines 1115 1119 +4 ==========================================
+ Hits 1003 1008 +5 + Misses 112 111 -1
FlagCoverage Δ
pytests90.08% <100.00%> (+0.12%)⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@claude
🐛 FIX: keep target anchors rendered in tab-set and tab-set-code
dd64f37
Follow-up to #271, which preserved target nodes but not their anchors:
- docutils PropagateTargets moves a preceding target's ids onto the
tab-item container, which TabSetHtmlTransform destroys — copy the
container's ids onto the rendered label so href targets exist
- tab-set-code dropped targets entirely (asymmetric with tab-set) —
preserve them the same way
- strengthen the target test to assert a rendered node carries the id
and that it appears in the built HTML (the previous assertions
passed against the broken output); add a tab-set-code variant
- get_started: clarify that examples may need extending
myst_enable_extensions beyond the snippet shown
@chrisjsewell
chrisjsewellforce-pushed the brief/07-target-anchors branch from 8a4720d to dd64f37CompareJuly 12, 2026 14:32
@chrisjsewell
chrisjsewell merged commit 9f62c7d into mainJul 12, 2026
25 checks passed
@chrisjsewell
chrisjsewell deleted the brief/07-target-anchors branch July 12, 2026 14:41
@chrisjsewellchrisjsewell mentioned this pull request Jul 12, 2026
Open
25 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@chrisjsewell@claude