Gate togglebutton.js console.log behind togglebuttonDebug - #78
Open
BetterAndBetterII wants to merge 1 commit into
Open
Gate togglebutton.js console.log behind togglebuttonDebug#78BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
Unconditional console.log in initToggleItems cluttered the browser console on every page load. Route leftover logs through a helper that only writes when togglebuttonDebug is set. Fixes executablebooks#56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initToggleItemsalways calledconsole.logwith the count of toggled items on every page load, which cluttered the browser console (#56). Two other leftoverconsole.logcalls in the same file had the same problem.Route those messages through a small
togglebuttonLoghelper that only writes whentogglebuttonDebugis set. Default behavior is silent; settogglebuttonDebug = truebefore the script runs to restore the previous messages.Test
Fixes #56