Skip to content

Bump GHA Ubuntu workflow runners to Ubuntu 26.04#1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahans merged 2 commits into from
Jul 13, 2026
Merged

Bump GHA Ubuntu workflow runners to Ubuntu 26.04 #1026

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cad034a
Bump GHA Ubuntu workflow runners to Ubuntu 26.04
IsaacG Jul 8, 2026
1e1168c
Revert min config changes
IsaacG Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,7 @@ jobs:
linux-latest:
name: Linux Latest Config
needs: [linux-min]
runs-on: ubuntu-24.04
runs-on: ubuntu-26.04
strategy:
matrix:
compiler: [clang++, g++]
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/pre-commit.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,7 @@ on:
jobs:
pre-commit:
name: Pre-commit checks
runs-on: ubuntu-22.04
runs-on: ubuntu-26.04
steps:
- name: Checkout code
uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd
Expand All@@ -20,7 +20,5 @@ jobs:
repository: ${{github.event.pull_request.head.repo.full_name}}
- name: Set up Python
uses: actions/setup-python@v6
with:
python-version: "3.10"
- name: Run pre-commit checks on PR
uses: pre-commit/action@v3.0.1
4 changes: 2 additions & 2 deletions exercises/practice/complex-numbers/test/catch_amalgamated.cpp
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -468,10 +468,10 @@ namespace Catch {
}

namespace literals {
Approx operator ""_a(long double val) {
Approx operator ""_a(long double val) {

@ahansahansJul 9, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we have this exact same file copied to each exercise. I'm not sure if changing only one is a good idea. If this fails on a newer compiler, we should probably upgrade Catch2 altogether (I feel we've discussed this and there was some reason not to upgrade, but I can't quite remember ...).

@IsaacGIsaacGJul 9, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to mass-apply this change across the repo.

@IsaacGIsaacGJul 9, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1027

@IsaacGIsaacGJul 9, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

exercism/cpp-test-runner#101

@ahansahansJul 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still puzzled why it shows only in the complex-numbers test ...

@IsaacGIsaacGJul 13, 2026

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm. That is odd. After #1027 is applied, it should no longer be there.

@ahansahansJul 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, both are merged now and tests still pass. I was just wondering why you needed only the fix for complex-numbers. But TBH I didn't do much digging to find out. It's definitely good to fix it for all exercises, since that also affected students on newer compilers working locally. It already showed in CI for the macos test, where we have -latest.

return Approx(val);
}
Approx operator ""_a(unsigned long long val) {
Approx operator ""_a(unsigned long long val) {
return Approx(val);
}
} // end namespace literals
Expand Down
Loading