Skip to content

Feat--add-kindergarten-garden-exercise - #804

Merged
vaeng merged 8 commits into
mainfrom
feat--add-kindergarten-garden-exercise
Feb 16, 2024
Merged

Feat--add-kindergarten-garden-exercise#804
vaeng merged 8 commits into
mainfrom
feat--add-kindergarten-garden-exercise

Conversation

@vaeng

@vaengvaeng commented Feb 12, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@vaengvaeng mentioned this pull request Feb 12, 2024
Closed
11 tasks
@vaengvaeng added x:module/practice-exercise Work on Practice Exercises x:rep/large Large amount of reputation labels Feb 12, 2024
ahans
ahans reviewed Feb 12, 2024
View reviewed changes
Comment threadexercises/practice/kindergarten-garden/.meta/example.h Outdated
Comment threadexercises/practice/kindergarten-garden/.meta/example.cpp Outdated
Comment threadexercises/practice/kindergarten-garden/.meta/example.cpp Outdated
Comment threadexercises/practice/kindergarten-garden/.meta/example.cpp Outdated
Comment threadexercises/practice/kindergarten-garden/.meta/example.h Outdated
ahans
ahans reviewed Feb 13, 2024
View reviewed changes

@ahansahans left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for considering my previous comments. Here's one more very minor one.

Comment threadexercises/practice/kindergarten-garden/.meta/example.h Outdated
@vaeng@ahans
fix: update enum with underlying type
3954181
Co-authored-by: Alexander Hans <ahans@users.noreply.github.com>
ahans
ahans reviewed Feb 14, 2024
View reviewed changes
Comment threadexercises/practice/kindergarten-garden/.meta/example.cpp
@vaeng
vaeng merged commit 4da6f15 into mainFeb 16, 2024
@vaeng
vaeng deleted the feat--add-kindergarten-garden-exercise branch February 16, 2024 08:52
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahansahansahans left review comments
@ErikSchierboomErikSchierboomErikSchierboom approved these changes
@siebenschlaefersiebenschlaeferAwaiting requested review from siebenschlaefer

Assignees

No one assigned

Labels

x:module/practice-exerciseWork on Practice Exercisesx:rep/largeLarge amount of reputation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vaeng@ErikSchierboom@ahans