Skip to content

Improve contributor experience - #654

Merged
mk-mxp merged 12 commits into
exercism:mainfrom
mk-mxp:improve-contributor-experience
Mar 7, 2024
Merged

Improve contributor experience#654
mk-mxp merged 12 commits into
exercism:mainfrom
mk-mxp:improve-contributor-experience

Conversation

@mk-mxp

@mk-mxpmk-mxp commented Mar 3, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Closes#620 and fixes issues with the GitHub actions workflow for PHPCS linting:

  • When a job has a strategy key, it must provide a matrix in that.
  • We don't need the PHPCS PHAR in CI anymore.

@mk-mxpmk-mxp self-assigned this Mar 3, 2024
@mk-mxpmk-mxp added x:action/improve Improve existing functionality/content x:knowledge/none No existing Exercism knowledge required x:type/ci Work on Continuous Integration (e.g. GitHub Actions workflows) x:type/coding Write code that is not student-facing content (e.g. test-runners, generators, but not exercises) x:size/medium Medium amount of work x:rep/medium Medium amount of reputation labels Mar 3, 2024
@mk-mxp
mk-mxpforce-pushed the improve-contributor-experience branch from e26596a to 9ea1692CompareMarch 3, 2024 10:49
homersimpsons
homersimpsons reviewed Mar 3, 2024
View reviewed changes

@homersimpsonshomersimpsons left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change regarding configlet are debatable. But let's do them and see if there is any negative feedback.

Comment threadREADME.md Outdated
Comment threadREADME.md
Comment threadcomposer.json Outdated
Comment threadcomposer.json Outdated
Comment threadcomposer.json Outdated
@mk-mxp
mk-mxpforce-pushed the improve-contributor-experience branch from 9ea1692 to 845574cCompareMarch 4, 2024 07:53
@mk-mxpmk-mxp mentioned this pull request Mar 4, 2024
Merged
1 task
@mk-mxp
mk-mxpforce-pushed the improve-contributor-experience branch from 845574c to 59aab70CompareMarch 4, 2024 17:27
@mk-mxp
mk-mxp merged commit d70c33a into exercism:mainMar 7, 2024
@mk-mxp
mk-mxp deleted the improve-contributor-experience branch March 7, 2024 07:51
tomasnorre pushed a commit to tomasnorre/exercism-php that referenced this pull request May 7, 2024
@mk-mxp@tomasnorre
Improve contributor experience (exercism#654)
212a922
* Add "configlet:fmt" command
* Combine all CI tests to command "ci"
* Install / update configlet with composer packages
* Remove PHP 7.4 from 'composer.json'
* Do not run composer scripts in CI
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@homersimpsonshomersimpsonshomersimpsons approved these changes

Assignees

@mk-mxpmk-mxp

Labels

x:action/improveImprove existing functionality/contentx:knowledge/noneNo existing Exercism knowledge requiredx:rep/mediumMedium amount of reputationx:size/mediumMedium amount of workx:type/ciWork on Continuous Integration (e.g. GitHub Actions workflows)x:type/codingWrite code that is not student-facing content (e.g. test-runners, generators, but not exercises)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve contributor experience

2 participants

@mk-mxp@homersimpsons