Uh oh!
There was an error while loading. Please reload this page.
Fix Meetup exercise tests - #665
Conversation
This requires adjusting the example solution to show it can still be done. Also remove superficial strict types file headers.
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
mk-mxp
commented
Mar 27, 2024
This change would invalidate a bunch of solutions, how can we prevent re-running tests for too old solutions? Or shouldn't we? |
homersimpsons
commented
Mar 27, 2024
I'm not sure how we should proceed about this, @ErikSchierboom do you have any suggestion? As this aligns the type to the student file stub, to me we should proceed with this change. It's been 3y this stub is like this, so I wouldn't expect this to break too much student code. This also aligns with the canonical-data.json from problem specifications. |
mk-mxp
commented
Mar 27, 2024
I just realized that this is the featured exercise for |
intas specified in students file stub.Follow-up of #592 (closed by creator)