[Sublist] Fix existing approaches & add new ones

[Yrahcaz7]

Fixes formatting and content of Sublist approaches as outlined here. (Will add at least one additional approach.)

Looking closer at the argument in this PR, I have have to say that I don't fully agree with either side. (Look at the changes in using-strings/content.md for further detail.)

[Yrahcaz7]

@BethanyG, if I use a slightly modified version of your Sublist solution for a sort-lists approach, should I add you in the contributors array for that approach? I'm still not sure how all this authors and contributors array stuff works.

[BethanyG]

@BethanyG, if I use a slightly modified version of your Sublist solution for a sort-lists approach, should I add you in the contributors array for that approach? I'm still not sure how all this authors and contributors array stuff works.

If that modification has lead to a whole new approach, I'd just put yourself as the author. I am happy being left off. My name is next to so much stuff, no need to invent more. 😄

[Yrahcaz7]

It's pretty much the same approach, the modifications are more minor. Here's the code:

SUBLIST=1SUPERLIST=2EQUAL=3UNEQUAL=4defsublist(list_one, list_two):
iflist_one==list_two:
returnEQUALifnot (list_oneandlist_two):
returnSUPERLISTiflist_oneelseSUBLISTshorter, longer=sorted((list_one, list_two), key=len)
forindexinrange(len(longer)):
iflonger[index : index+len(shorter)] ==shorter:
returnSUPERLISTiflongerislist_oneelseSUBLISTreturnUNEQUAL

[BethanyG]

still happy being left off. 😄 It's all yours!

Edited to add: Needed a bit of a break, so have been doing some knitting. So I might be a tad slower to answer for a bit. Will get back to things in a bit. 😄

[Yrahcaz7]

@BethanyG I ended up modifying it a bit more (mostly because I noticed it could be a bit more optimal when the arguments are UNEQUAL). The PR should ready for review now.

Edit: Whoops, there was a copy-paste error I missed. Should be ready for real now.

[BethanyG]

Only putting in request changes so that we discuss this a bit more. Overall, this is looking really good. I just want to make sure we are really clear with that PyLint rule and the explanation in the helper function approach. 😄

[Yrahcaz7]

Uh... Git went a little weird there because I forgot to pull origin before making more changes. Hopefully I didn't break anything?

[BethanyG]

Uh... Git went a little weird there because I forgot to pull origin before making more changes. Hopefully I didn't break anything?

It doesn't look like it to me....I can still see all the files and changes and there doesn't appear to be any duplicates or merge conflicts.

Nice work you! Shall we let this sit and re-review, or are you ready to push the big, green button? 😄

[Yrahcaz7]

🤔 I'm feeling a little more confident this time... Maybe it's time to push the big green button!

[BethanyG]

Smooshed and merged!!