Skip to content

[RNA Transcription & Atbash Cipher]: Approaches Cleanup - #4191

Merged
BethanyG merged 4 commits into
exercism:mainfrom
Yrahcaz7:rna-atbash-approach-cleanup
May 19, 2026
Merged

[RNA Transcription & Atbash Cipher]: Approaches Cleanup#4191
BethanyG merged 4 commits into
exercism:mainfrom
Yrahcaz7:rna-atbash-approach-cleanup

Conversation

@Yrahcaz7

@Yrahcaz7Yrahcaz7 commented May 19, 2026

Copy link
Copy Markdown
Contributor

As discussed in this issue.

BethanyG
BethanyG requested changes May 19, 2026
View reviewed changes

@BethanyGBethanyG left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am being a pendant here, but I think it is really important to poke students about "character" vs "code point". We have to be careful, even with basic ASCII to not confuse the two - it becomes a deadly mental model the minute you get to anything with a diacritical mark or accent. Its even worse when you work with any multi-codepoint glyphs (like emoji or Kanji). It's a ...whole thing.

Otherwise, great work here. Thanks so much for cleaning this mess up.

Comment threadexercises/practice/atbash-cipher/.approaches/mono-function/content.md Outdated
Comment threadexercises/practice/atbash-cipher/.approaches/mono-function/content.md Outdated
Comment threadexercises/practice/atbash-cipher/.approaches/mono-function/content.md Outdated
Comment threadexercises/practice/atbash-cipher/.approaches/mono-function/content.md Outdated
Comment threadexercises/practice/atbash-cipher/.approaches/mono-function/content.md Outdated
Comment threadexercises/practice/atbash-cipher/.approaches/mono-function/content.md Outdated
Comment threadexercises/practice/atbash-cipher/.approaches/mono-function/content.md
Comment threadexercises/practice/atbash-cipher/.approaches/introduction.md Outdated
Comment threadexercises/practice/atbash-cipher/.approaches/introduction.md Outdated
Comment threadexercises/practice/rna-transcription/.approaches/dictionary-join/content.md Outdated
@Yrahcaz7@BethanyG
Apply suggestions from code review
aaa4ba3
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Yrahcaz7
Yrahcaz7 commented May 19, 2026
View reviewed changes
Comment threadexercises/practice/atbash-cipher/.approaches/separate-functions/content.md Outdated
BethanyG
BethanyG approved these changes May 19, 2026
View reviewed changes

@BethanyGBethanyG left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a tad triggered by those last "character" refs but agree they are better as-is for clarity. (Or at least I hope that brings clarity).

@BethanyG

BethanyG commented May 19, 2026

Copy link
Copy Markdown
Member

Shall we let this one sit and re-read, or are you read for merge? 😄

@Yrahcaz7

Yrahcaz7 commented May 19, 2026

Copy link
Copy Markdown
ContributorAuthor

You bet I am ready to merge! I am not letting that slop err... subpar approach remain there any longer!

@BethanyG
BethanyG merged commit 79149c3 into exercism:mainMay 19, 2026
7 checks passed
@BethanyG

BethanyG commented May 19, 2026

Copy link
Copy Markdown
Member

BTW, if another approach for any of these comes to you, please feel free to write one (or not!).

@Yrahcaz7
Yrahcaz7 deleted the rna-atbash-approach-cleanup branch May 19, 2026 22:41
@Yrahcaz7Yrahcaz7 mentioned this pull request May 21, 2026
Open
@BethanyGBethanyG changed the title RNA Transcription and Atbash Cipher approach cleanup[RNA Transcription & Atbash Cipher]: Approaches CleanupJun 4, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BethanyGBethanyGBethanyG approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Yrahcaz7@BethanyG