Close multipart review findings left open on #75's branch

[ernestoongaro]

Stacked onto feat/body-file-input, where the multipart work now lives as ffebcee. #72's review (n8's pass plus Copilot's inline comments) turned up findings that 3d9b0e1 and 0827738 partly covered — the body-flag Changed state and the file-path hint. These are the ones nothing on this branch has picked up yet.

Fixes

Finding	Symptom
~ never expanded for binary field paths	--file ~/people.csv → no such file or directory, unlike --body @~/x.json
--body null decodes into a nil map	panic: assignment to entry in nil map on the first generated flag merged in
array/object flag values decode into interface{}	an object is accepted where the schema says array; --labels '["a"] oops' silently sends ["a"]
registerMultipartFlags doesn't recheck its form- replacement	two fields colliding on one flag name register the same pflag twice and panic at startup — every command dies, not just the upload
requestBodyMediaType has no nil-schema guard	a schema-less application/json entry can shadow a real multipart definition

The last two are latent: the current spec doesn't trigger either.

Verification

• go build ./..., go vet ./..., go test ./...
• one regression test per fix; with the source changes stashed, the tilde test fails and the null-body test panics

Not addressed

Copilot flagged that the upload file is buffered into a bytes.Buffer before the request starts, with no size cap. Streaming it means threading an io.Reader through APIRequest and internal/auth — wider than a review-fix pass, and worth its own change if uploads are expected to get large.

Nit, not touched here

operationInfo.bodyFlagIsJSON (generate.go:448) is dead on this branch — 3d9b0e1 dropped resolveBody's validateJSON parameter and nothing calls the method now. Its comment still describes the old behavior. Left alone since it isn't mine to reshape, but it will read as live plumbing to the next person.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DYuiGGkmQifkCbF2qL8Lt6

[ernestoongaro]

Stacked onto feat/body-file-input, where the multipart work now lives as ffebcee. #72's review (n8's pass plus Copilot's inline comments) turned up findings that 3d9b0e1 and 0827738 partly covered — the body-flag Changed state and the file-path hint. These are the ones nothing on this branch has picked up yet.

Fixes

Finding	Symptom
~ never expanded for binary field paths	--file ~/people.csv → no such file or directory, unlike --body @~/x.json
--body null decodes into a nil map	panic: assignment to entry in nil map on the first generated flag merged in
array/object flag values decode into interface{}	an object is accepted where the schema says array; --labels '["a"] oops' silently sends ["a"]
registerMultipartFlags doesn't recheck its form- replacement	two fields colliding on one flag name register the same pflag twice and panic at startup — every command dies, not just the upload
requestBodyMediaType has no nil-schema guard	a schema-less application/json entry can shadow a real multipart definition

The last two are latent: the current spec doesn't trigger either.

Verification

• go build ./..., go vet ./..., go test ./...
• one regression test per fix; with the source changes stashed, the tilde test fails and the null-body test panics

Not addressed

Copilot flagged that the upload file is buffered into a bytes.Buffer before the request starts, with no size cap. Streaming it means threading an io.Reader through APIRequest and internal/auth — wider than a review-fix pass, and worth its own change if uploads are expected to get large.

Nit, not touched here

operationInfo.bodyFlagIsJSON (generate.go:448) is dead on this branch — 3d9b0e1 dropped resolveBody's validateJSON parameter and nothing calls the method now. Its comment still describes the old behavior. Left alone since it isn't mine to reshape, but it will read as live plumbing to the next person.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DYuiGGkmQifkCbF2qL8Lt6

[ernestoongaro]

Stacked onto feat/body-file-input, where the multipart work now lives as ffebcee. #72's review (n8's pass plus Copilot's inline comments) turned up findings that 3d9b0e1 and 0827738 partly covered — the body-flag Changed state and the file-path hint. These are the ones nothing on this branch has picked up yet.

Fixes

Finding	Symptom
~ never expanded for binary field paths	--file ~/people.csv → no such file or directory, unlike --body @~/x.json
--body null decodes into a nil map	panic: assignment to entry in nil map on the first generated flag merged in
array/object flag values decode into interface{}	an object is accepted where the schema says array; --labels '["a"] oops' silently sends ["a"]
registerMultipartFlags doesn't recheck its form- replacement	two fields colliding on one flag name register the same pflag twice and panic at startup — every command dies, not just the upload
requestBodyMediaType has no nil-schema guard	a schema-less application/json entry can shadow a real multipart definition

The last two are latent: the current spec doesn't trigger either.

Verification

• go build ./..., go vet ./..., go test ./...
• one regression test per fix; with the source changes stashed, the tilde test fails and the null-body test panics

Not addressed

Copilot flagged that the upload file is buffered into a bytes.Buffer before the request starts, with no size cap. Streaming it means threading an io.Reader through APIRequest and internal/auth — wider than a review-fix pass, and worth its own change if uploads are expected to get large.

Nit, not touched here

operationInfo.bodyFlagIsJSON (generate.go:448) is dead on this branch — 3d9b0e1 dropped resolveBody's validateJSON parameter and nothing calls the method now. Its comment still describes the old behavior. Left alone since it isn't mine to reshape, but it will read as live plumbing to the next person.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DYuiGGkmQifkCbF2qL8Lt6

[ernestoongaro]

Stacked onto feat/body-file-input, where the multipart work now lives as ffebcee. #72's review (n8's pass plus Copilot's inline comments) turned up findings that 3d9b0e1 and 0827738 partly covered — the body-flag Changed state and the file-path hint. These are the ones nothing on this branch has picked up yet.

Fixes

Finding	Symptom
~ never expanded for binary field paths	--file ~/people.csv → no such file or directory, unlike --body @~/x.json
--body null decodes into a nil map	panic: assignment to entry in nil map on the first generated flag merged in
array/object flag values decode into interface{}	an object is accepted where the schema says array; --labels '["a"] oops' silently sends ["a"]
registerMultipartFlags doesn't recheck its form- replacement	two fields colliding on one flag name register the same pflag twice and panic at startup — every command dies, not just the upload
requestBodyMediaType has no nil-schema guard	a schema-less application/json entry can shadow a real multipart definition

The last two are latent: the current spec doesn't trigger either.

Verification

• go build ./..., go vet ./..., go test ./...
• one regression test per fix; with the source changes stashed, the tilde test fails and the null-body test panics

Not addressed

Copilot flagged that the upload file is buffered into a bytes.Buffer before the request starts, with no size cap. Streaming it means threading an io.Reader through APIRequest and internal/auth — wider than a review-fix pass, and worth its own change if uploads are expected to get large.

Nit, not touched here

operationInfo.bodyFlagIsJSON (generate.go:448) is dead on this branch — 3d9b0e1 dropped resolveBody's validateJSON parameter and nothing calls the method now. Its comment still describes the old behavior. Left alone since it isn't mine to reshape, but it will read as live plumbing to the next person.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DYuiGGkmQifkCbF2qL8Lt6

[ernestoongaro]

Stacked onto feat/body-file-input, where the multipart work now lives as ffebcee. #72's review (n8's pass plus Copilot's inline comments) turned up findings that 3d9b0e1 and 0827738 partly covered — the body-flag Changed state and the file-path hint. These are the ones nothing on this branch has picked up yet.

Fixes

Finding	Symptom
~ never expanded for binary field paths	--file ~/people.csv → no such file or directory, unlike --body @~/x.json
--body null decodes into a nil map	panic: assignment to entry in nil map on the first generated flag merged in
array/object flag values decode into interface{}	an object is accepted where the schema says array; --labels '["a"] oops' silently sends ["a"]
registerMultipartFlags doesn't recheck its form- replacement	two fields colliding on one flag name register the same pflag twice and panic at startup — every command dies, not just the upload
requestBodyMediaType has no nil-schema guard	a schema-less application/json entry can shadow a real multipart definition

The last two are latent: the current spec doesn't trigger either.

Verification

• go build ./..., go vet ./..., go test ./...
• one regression test per fix; with the source changes stashed, the tilde test fails and the null-body test panics

Not addressed

Copilot flagged that the upload file is buffered into a bytes.Buffer before the request starts, with no size cap. Streaming it means threading an io.Reader through APIRequest and internal/auth — wider than a review-fix pass, and worth its own change if uploads are expected to get large.

Nit, not touched here

operationInfo.bodyFlagIsJSON (generate.go:448) is dead on this branch — 3d9b0e1 dropped resolveBody's validateJSON parameter and nothing calls the method now. Its comment still describes the old behavior. Left alone since it isn't mine to reshape, but it will read as live plumbing to the next person.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DYuiGGkmQifkCbF2qL8Lt6

[ernestoongaro]

Stacked onto feat/body-file-input, where the multipart work now lives as ffebcee. #72's review (n8's pass plus Copilot's inline comments) turned up findings that 3d9b0e1 and 0827738 partly covered — the body-flag Changed state and the file-path hint. These are the ones nothing on this branch has picked up yet.

Fixes

Finding	Symptom
~ never expanded for binary field paths	--file ~/people.csv → no such file or directory, unlike --body @~/x.json
--body null decodes into a nil map	panic: assignment to entry in nil map on the first generated flag merged in
array/object flag values decode into interface{}	an object is accepted where the schema says array; --labels '["a"] oops' silently sends ["a"]
registerMultipartFlags doesn't recheck its form- replacement	two fields colliding on one flag name register the same pflag twice and panic at startup — every command dies, not just the upload
requestBodyMediaType has no nil-schema guard	a schema-less application/json entry can shadow a real multipart definition

The last two are latent: the current spec doesn't trigger either.

Verification

• go build ./..., go vet ./..., go test ./...
• one regression test per fix; with the source changes stashed, the tilde test fails and the null-body test panics

Not addressed

Copilot flagged that the upload file is buffered into a bytes.Buffer before the request starts, with no size cap. Streaming it means threading an io.Reader through APIRequest and internal/auth — wider than a review-fix pass, and worth its own change if uploads are expected to get large.

Nit, not touched here

operationInfo.bodyFlagIsJSON (generate.go:448) is dead on this branch — 3d9b0e1 dropped resolveBody's validateJSON parameter and nothing calls the method now. Its comment still describes the old behavior. Left alone since it isn't mine to reshape, but it will read as live plumbing to the next person.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DYuiGGkmQifkCbF2qL8Lt6

[ernestoongaro]

Stacked onto feat/body-file-input, where the multipart work now lives as ffebcee. #72's review (n8's pass plus Copilot's inline comments) turned up findings that 3d9b0e1 and 0827738 partly covered — the body-flag Changed state and the file-path hint. These are the ones nothing on this branch has picked up yet.

Fixes

Finding	Symptom
~ never expanded for binary field paths	--file ~/people.csv → no such file or directory, unlike --body @~/x.json
--body null decodes into a nil map	panic: assignment to entry in nil map on the first generated flag merged in
array/object flag values decode into interface{}	an object is accepted where the schema says array; --labels '["a"] oops' silently sends ["a"]
registerMultipartFlags doesn't recheck its form- replacement	two fields colliding on one flag name register the same pflag twice and panic at startup — every command dies, not just the upload
requestBodyMediaType has no nil-schema guard	a schema-less application/json entry can shadow a real multipart definition

The last two are latent: the current spec doesn't trigger either.

Verification

• go build ./..., go vet ./..., go test ./...
• one regression test per fix; with the source changes stashed, the tilde test fails and the null-body test panics

Not addressed

Copilot flagged that the upload file is buffered into a bytes.Buffer before the request starts, with no size cap. Streaming it means threading an io.Reader through APIRequest and internal/auth — wider than a review-fix pass, and worth its own change if uploads are expected to get large.

Nit, not touched here

operationInfo.bodyFlagIsJSON (generate.go:448) is dead on this branch — 3d9b0e1 dropped resolveBody's validateJSON parameter and nothing calls the method now. Its comment still describes the old behavior. Left alone since it isn't mine to reshape, but it will read as live plumbing to the next person.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DYuiGGkmQifkCbF2qL8Lt6

[ernestoongaro]

Stacked onto feat/body-file-input, where the multipart work now lives as ffebcee. #72's review (n8's pass plus Copilot's inline comments) turned up findings that 3d9b0e1 and 0827738 partly covered — the body-flag Changed state and the file-path hint. These are the ones nothing on this branch has picked up yet.

Fixes

Finding	Symptom
~ never expanded for binary field paths	--file ~/people.csv → no such file or directory, unlike --body @~/x.json
--body null decodes into a nil map	panic: assignment to entry in nil map on the first generated flag merged in
array/object flag values decode into interface{}	an object is accepted where the schema says array; --labels '["a"] oops' silently sends ["a"]
registerMultipartFlags doesn't recheck its form- replacement	two fields colliding on one flag name register the same pflag twice and panic at startup — every command dies, not just the upload
requestBodyMediaType has no nil-schema guard	a schema-less application/json entry can shadow a real multipart definition

The last two are latent: the current spec doesn't trigger either.

Verification

• go build ./..., go vet ./..., go test ./...
• one regression test per fix; with the source changes stashed, the tilde test fails and the null-body test panics

Not addressed

Copilot flagged that the upload file is buffered into a bytes.Buffer before the request starts, with no size cap. Streaming it means threading an io.Reader through APIRequest and internal/auth — wider than a review-fix pass, and worth its own change if uploads are expected to get large.

Nit, not touched here

operationInfo.bodyFlagIsJSON (generate.go:448) is dead on this branch — 3d9b0e1 dropped resolveBody's validateJSON parameter and nothing calls the method now. Its comment still describes the old behavior. Left alone since it isn't mine to reshape, but it will read as live plumbing to the next person.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DYuiGGkmQifkCbF2qL8Lt6