Skip to content

fix(output): unwrap nested error objects; fix --result-type docs; agent-help name-vs-UUID examples - #88

Merged
ernestoongaro merged 2 commits into
mainfrom
fix/error-unwrap-and-docs
Aug 28, 2026
Merged

fix(output): unwrap nested error objects; fix --result-type docs; agent-help name-vs-UUID examples#88
ernestoongaro merged 2 commits into
mainfrom
fix/error-unwrap-and-docs

Conversation

@ernestoongaro

Copy link
Copy Markdown
Collaborator

Three small things from a full sweep of the CLI against a playground instance.

  1. Nested error bodies.{"error":{"code":403,"message":"Invalid bearer token"}} (what a bad token returns) was surfaced as the whole object re-serialised into "error". extractErrorDetail now descends one level into an object-valued detail/message/error key. Before/after:

    "error": "{\"error\":{\"code\":403,\"message\":\"Invalid bearer token\"}}"
    "error": "Invalid bearer token"
    

    Test added; fallback to the raw body is unchanged when no message is found.

  2. Docs.CLAUDE.md and an output.go comment referred to a --result-type flag that doesn't exist — CSV/XLSX come from query run's resultType body field.

  3. agent-help. The existing "some positionals take a NAME, not a UUID" note gains the other cases that tripped a scripted sweep (delete-branch, labels get, documents add-label, users get-model-roles <membership-id>). The spec and --help already describe each correctly; this is reinforcement only, easy to drop if unwanted.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ei8UYaG1bW5PJhk93EaqzA

…sult-type docs
Auth failures come back as {"error":{"code":403,"message":"Invalid bearer
token"}}. extractErrorDetail only accepted string values for detail/message/
error, so the whole object was re-serialised into the "error" field:
"error": "{\"error\":{\"code\":403,\"message\":\"Invalid bearer token\"}}".
Descend one level into an object-valued key and take its message/detail.
CLAUDE.md and a comment in output.go referred to a --result-type flag that
does not exist; CSV/XLSX come from query run's "resultType" body field.
agent-help's "some positionals take a NAME" note gains the other cases that
tripped a scripted sweep: delete-branch, labels, document labels, and the
membership-ID argument of users get-model-roles. The spec and --help already
describe each of these correctly; this is a cross-cutting reminder only.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ei8UYaG1bW5PJhk93EaqzA

@dspangendspangen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex says:

One minor documentation issue; no functional defects found.

[P3] Remove the remaining obsolete flag reference

cmd/omni/output_test.go:188 still says XLSX is selected with --result-type, although this PR establishes that the flag does not exist. Please update it to reference the query run body’s resultType field so the cleanup is complete.

The nested error extraction itself looks correct and preserves existing fallback behavior. GitHub CI reports both lint and test passing.

@ernestoongaro

Copy link
Copy Markdown
CollaboratorAuthor

Fixed in f926995output_test.go:188 was the last --result-type reference in the repo (grep is now clean); it now reads as the resultType body field like the others.

@ernestoongaro
ernestoongaro merged commit 43fe1a7 into mainAug 28, 2026
2 checks passed
@ernestoongaro
ernestoongaro deleted the fix/error-unwrap-and-docs branch August 28, 2026 14:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ernestoongaro@dspangen
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix(output): unwrap nested error objects; fix --result-type docs; agent-help name-vs-UUID examples by ernestoongaro · Pull Request #88 · exploreomni/cli · GitHub
Skip to content

fix(output): unwrap nested error objects; fix --result-type docs; agent-help name-vs-UUID examples - #88

Merged
ernestoongaro merged 2 commits into
mainfrom
fix/error-unwrap-and-docs
Aug 28, 2026
Merged

fix(output): unwrap nested error objects; fix --result-type docs; agent-help name-vs-UUID examples#88
ernestoongaro merged 2 commits into
mainfrom
fix/error-unwrap-and-docs

Conversation

@ernestoongaro

Copy link
Copy Markdown
Collaborator

Three small things from a full sweep of the CLI against a playground instance.

  1. Nested error bodies.{"error":{"code":403,"message":"Invalid bearer token"}} (what a bad token returns) was surfaced as the whole object re-serialised into "error". extractErrorDetail now descends one level into an object-valued detail/message/error key. Before/after:

    "error": "{\"error\":{\"code\":403,\"message\":\"Invalid bearer token\"}}"
    "error": "Invalid bearer token"
    

    Test added; fallback to the raw body is unchanged when no message is found.

  2. Docs.CLAUDE.md and an output.go comment referred to a --result-type flag that doesn't exist — CSV/XLSX come from query run's resultType body field.

  3. agent-help. The existing "some positionals take a NAME, not a UUID" note gains the other cases that tripped a scripted sweep (delete-branch, labels get, documents add-label, users get-model-roles <membership-id>). The spec and --help already describe each correctly; this is reinforcement only, easy to drop if unwanted.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ei8UYaG1bW5PJhk93EaqzA

…sult-type docs
Auth failures come back as {"error":{"code":403,"message":"Invalid bearer
token"}}. extractErrorDetail only accepted string values for detail/message/
error, so the whole object was re-serialised into the "error" field:
"error": "{\"error\":{\"code\":403,\"message\":\"Invalid bearer token\"}}".
Descend one level into an object-valued key and take its message/detail.
CLAUDE.md and a comment in output.go referred to a --result-type flag that
does not exist; CSV/XLSX come from query run's "resultType" body field.
agent-help's "some positionals take a NAME" note gains the other cases that
tripped a scripted sweep: delete-branch, labels, document labels, and the
membership-ID argument of users get-model-roles. The spec and --help already
describe each of these correctly; this is a cross-cutting reminder only.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ei8UYaG1bW5PJhk93EaqzA

@dspangendspangen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex says:

One minor documentation issue; no functional defects found.

[P3] Remove the remaining obsolete flag reference

cmd/omni/output_test.go:188 still says XLSX is selected with --result-type, although this PR establishes that the flag does not exist. Please update it to reference the query run body’s resultType field so the cleanup is complete.

The nested error extraction itself looks correct and preserves existing fallback behavior. GitHub CI reports both lint and test passing.

@ernestoongaro

Copy link
Copy Markdown
CollaboratorAuthor

Fixed in f926995output_test.go:188 was the last --result-type reference in the repo (grep is now clean); it now reads as the resultType body field like the others.

@ernestoongaro
ernestoongaro merged commit 43fe1a7 into mainAug 28, 2026
2 checks passed
@ernestoongaro
ernestoongaro deleted the fix/error-unwrap-and-docs branch August 28, 2026 14:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ernestoongaro@dspangen
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(output): unwrap nested error objects; fix --result-type docs; agent-help name-vs-UUID examples by ernestoongaro · Pull Request #88 · exploreomni/cli · GitHub
Skip to content

fix(output): unwrap nested error objects; fix --result-type docs; agent-help name-vs-UUID examples - #88

Merged
ernestoongaro merged 2 commits into
mainfrom
fix/error-unwrap-and-docs
Aug 28, 2026
Merged

fix(output): unwrap nested error objects; fix --result-type docs; agent-help name-vs-UUID examples#88
ernestoongaro merged 2 commits into
mainfrom
fix/error-unwrap-and-docs

Conversation

@ernestoongaro

Copy link
Copy Markdown
Collaborator

Three small things from a full sweep of the CLI against a playground instance.

  1. Nested error bodies.{"error":{"code":403,"message":"Invalid bearer token"}} (what a bad token returns) was surfaced as the whole object re-serialised into "error". extractErrorDetail now descends one level into an object-valued detail/message/error key. Before/after:

    "error": "{\"error\":{\"code\":403,\"message\":\"Invalid bearer token\"}}"
    "error": "Invalid bearer token"
    

    Test added; fallback to the raw body is unchanged when no message is found.

  2. Docs.CLAUDE.md and an output.go comment referred to a --result-type flag that doesn't exist — CSV/XLSX come from query run's resultType body field.

  3. agent-help. The existing "some positionals take a NAME, not a UUID" note gains the other cases that tripped a scripted sweep (delete-branch, labels get, documents add-label, users get-model-roles <membership-id>). The spec and --help already describe each correctly; this is reinforcement only, easy to drop if unwanted.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ei8UYaG1bW5PJhk93EaqzA

…sult-type docs
Auth failures come back as {"error":{"code":403,"message":"Invalid bearer
token"}}. extractErrorDetail only accepted string values for detail/message/
error, so the whole object was re-serialised into the "error" field:
"error": "{\"error\":{\"code\":403,\"message\":\"Invalid bearer token\"}}".
Descend one level into an object-valued key and take its message/detail.
CLAUDE.md and a comment in output.go referred to a --result-type flag that
does not exist; CSV/XLSX come from query run's "resultType" body field.
agent-help's "some positionals take a NAME" note gains the other cases that
tripped a scripted sweep: delete-branch, labels, document labels, and the
membership-ID argument of users get-model-roles. The spec and --help already
describe each of these correctly; this is a cross-cutting reminder only.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ei8UYaG1bW5PJhk93EaqzA

@dspangendspangen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex says:

One minor documentation issue; no functional defects found.

[P3] Remove the remaining obsolete flag reference

cmd/omni/output_test.go:188 still says XLSX is selected with --result-type, although this PR establishes that the flag does not exist. Please update it to reference the query run body’s resultType field so the cleanup is complete.

The nested error extraction itself looks correct and preserves existing fallback behavior. GitHub CI reports both lint and test passing.

@ernestoongaro

Copy link
Copy Markdown
CollaboratorAuthor

Fixed in f926995output_test.go:188 was the last --result-type reference in the repo (grep is now clean); it now reads as the resultType body field like the others.

@ernestoongaro
ernestoongaro merged commit 43fe1a7 into mainAug 28, 2026
2 checks passed
@ernestoongaro
ernestoongaro deleted the fix/error-unwrap-and-docs branch August 28, 2026 14:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ernestoongaro@dspangen
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(output): unwrap nested error objects; fix --result-type docs; agent-help name-vs-UUID examples by ernestoongaro · Pull Request #88 · exploreomni/cli · GitHub
Skip to content

fix(output): unwrap nested error objects; fix --result-type docs; agent-help name-vs-UUID examples - #88

Merged
ernestoongaro merged 2 commits into
mainfrom
fix/error-unwrap-and-docs
Aug 28, 2026
Merged

fix(output): unwrap nested error objects; fix --result-type docs; agent-help name-vs-UUID examples#88
ernestoongaro merged 2 commits into
mainfrom
fix/error-unwrap-and-docs

Conversation

@ernestoongaro

Copy link
Copy Markdown
Collaborator

Three small things from a full sweep of the CLI against a playground instance.

  1. Nested error bodies.{"error":{"code":403,"message":"Invalid bearer token"}} (what a bad token returns) was surfaced as the whole object re-serialised into "error". extractErrorDetail now descends one level into an object-valued detail/message/error key. Before/after:

    "error": "{\"error\":{\"code\":403,\"message\":\"Invalid bearer token\"}}"
    "error": "Invalid bearer token"
    

    Test added; fallback to the raw body is unchanged when no message is found.

  2. Docs.CLAUDE.md and an output.go comment referred to a --result-type flag that doesn't exist — CSV/XLSX come from query run's resultType body field.

  3. agent-help. The existing "some positionals take a NAME, not a UUID" note gains the other cases that tripped a scripted sweep (delete-branch, labels get, documents add-label, users get-model-roles <membership-id>). The spec and --help already describe each correctly; this is reinforcement only, easy to drop if unwanted.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ei8UYaG1bW5PJhk93EaqzA

…sult-type docs
Auth failures come back as {"error":{"code":403,"message":"Invalid bearer
token"}}. extractErrorDetail only accepted string values for detail/message/
error, so the whole object was re-serialised into the "error" field:
"error": "{\"error\":{\"code\":403,\"message\":\"Invalid bearer token\"}}".
Descend one level into an object-valued key and take its message/detail.
CLAUDE.md and a comment in output.go referred to a --result-type flag that
does not exist; CSV/XLSX come from query run's "resultType" body field.
agent-help's "some positionals take a NAME" note gains the other cases that
tripped a scripted sweep: delete-branch, labels, document labels, and the
membership-ID argument of users get-model-roles. The spec and --help already
describe each of these correctly; this is a cross-cutting reminder only.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ei8UYaG1bW5PJhk93EaqzA

@dspangendspangen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex says:

One minor documentation issue; no functional defects found.

[P3] Remove the remaining obsolete flag reference

cmd/omni/output_test.go:188 still says XLSX is selected with --result-type, although this PR establishes that the flag does not exist. Please update it to reference the query run body’s resultType field so the cleanup is complete.

The nested error extraction itself looks correct and preserves existing fallback behavior. GitHub CI reports both lint and test passing.

@ernestoongaro

Copy link
Copy Markdown
CollaboratorAuthor

Fixed in f926995output_test.go:188 was the last --result-type reference in the repo (grep is now clean); it now reads as the resultType body field like the others.

@ernestoongaro
ernestoongaro merged commit 43fe1a7 into mainAug 28, 2026
2 checks passed
@ernestoongaro
ernestoongaro deleted the fix/error-unwrap-and-docs branch August 28, 2026 14:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ernestoongaro@dspangen
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix(output): unwrap nested error objects; fix --result-type docs; agent-help name-vs-UUID examples by ernestoongaro · Pull Request #88 · exploreomni/cli · GitHub
Skip to content

fix(output): unwrap nested error objects; fix --result-type docs; agent-help name-vs-UUID examples - #88

Merged
ernestoongaro merged 2 commits into
mainfrom
fix/error-unwrap-and-docs
Aug 28, 2026
Merged

fix(output): unwrap nested error objects; fix --result-type docs; agent-help name-vs-UUID examples#88
ernestoongaro merged 2 commits into
mainfrom
fix/error-unwrap-and-docs

Conversation

@ernestoongaro

Copy link
Copy Markdown
Collaborator

Three small things from a full sweep of the CLI against a playground instance.

  1. Nested error bodies.{"error":{"code":403,"message":"Invalid bearer token"}} (what a bad token returns) was surfaced as the whole object re-serialised into "error". extractErrorDetail now descends one level into an object-valued detail/message/error key. Before/after:

    "error": "{\"error\":{\"code\":403,\"message\":\"Invalid bearer token\"}}"
    "error": "Invalid bearer token"
    

    Test added; fallback to the raw body is unchanged when no message is found.

  2. Docs.CLAUDE.md and an output.go comment referred to a --result-type flag that doesn't exist — CSV/XLSX come from query run's resultType body field.

  3. agent-help. The existing "some positionals take a NAME, not a UUID" note gains the other cases that tripped a scripted sweep (delete-branch, labels get, documents add-label, users get-model-roles <membership-id>). The spec and --help already describe each correctly; this is reinforcement only, easy to drop if unwanted.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ei8UYaG1bW5PJhk93EaqzA

…sult-type docs
Auth failures come back as {"error":{"code":403,"message":"Invalid bearer
token"}}. extractErrorDetail only accepted string values for detail/message/
error, so the whole object was re-serialised into the "error" field:
"error": "{\"error\":{\"code\":403,\"message\":\"Invalid bearer token\"}}".
Descend one level into an object-valued key and take its message/detail.
CLAUDE.md and a comment in output.go referred to a --result-type flag that
does not exist; CSV/XLSX come from query run's "resultType" body field.
agent-help's "some positionals take a NAME" note gains the other cases that
tripped a scripted sweep: delete-branch, labels, document labels, and the
membership-ID argument of users get-model-roles. The spec and --help already
describe each of these correctly; this is a cross-cutting reminder only.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ei8UYaG1bW5PJhk93EaqzA

@dspangendspangen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex says:

One minor documentation issue; no functional defects found.

[P3] Remove the remaining obsolete flag reference

cmd/omni/output_test.go:188 still says XLSX is selected with --result-type, although this PR establishes that the flag does not exist. Please update it to reference the query run body’s resultType field so the cleanup is complete.

The nested error extraction itself looks correct and preserves existing fallback behavior. GitHub CI reports both lint and test passing.

@ernestoongaro

Copy link
Copy Markdown
CollaboratorAuthor

Fixed in f926995output_test.go:188 was the last --result-type reference in the repo (grep is now clean); it now reads as the resultType body field like the others.

@ernestoongaro
ernestoongaro merged commit 43fe1a7 into mainAug 28, 2026
2 checks passed
@ernestoongaro
ernestoongaro deleted the fix/error-unwrap-and-docs branch August 28, 2026 14:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ernestoongaro@dspangen
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix(output): unwrap nested error objects; fix --result-type docs; agent-help name-vs-UUID examples by ernestoongaro · Pull Request #88 · exploreomni/cli · GitHub
Skip to content

fix(output): unwrap nested error objects; fix --result-type docs; agent-help name-vs-UUID examples - #88

Merged
ernestoongaro merged 2 commits into
mainfrom
fix/error-unwrap-and-docs
Aug 28, 2026
Merged

fix(output): unwrap nested error objects; fix --result-type docs; agent-help name-vs-UUID examples#88
ernestoongaro merged 2 commits into
mainfrom
fix/error-unwrap-and-docs

Conversation

@ernestoongaro

Copy link
Copy Markdown
Collaborator

Three small things from a full sweep of the CLI against a playground instance.

  1. Nested error bodies.{"error":{"code":403,"message":"Invalid bearer token"}} (what a bad token returns) was surfaced as the whole object re-serialised into "error". extractErrorDetail now descends one level into an object-valued detail/message/error key. Before/after:

    "error": "{\"error\":{\"code\":403,\"message\":\"Invalid bearer token\"}}"
    "error": "Invalid bearer token"
    

    Test added; fallback to the raw body is unchanged when no message is found.

  2. Docs.CLAUDE.md and an output.go comment referred to a --result-type flag that doesn't exist — CSV/XLSX come from query run's resultType body field.

  3. agent-help. The existing "some positionals take a NAME, not a UUID" note gains the other cases that tripped a scripted sweep (delete-branch, labels get, documents add-label, users get-model-roles <membership-id>). The spec and --help already describe each correctly; this is reinforcement only, easy to drop if unwanted.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ei8UYaG1bW5PJhk93EaqzA

…sult-type docs
Auth failures come back as {"error":{"code":403,"message":"Invalid bearer
token"}}. extractErrorDetail only accepted string values for detail/message/
error, so the whole object was re-serialised into the "error" field:
"error": "{\"error\":{\"code\":403,\"message\":\"Invalid bearer token\"}}".
Descend one level into an object-valued key and take its message/detail.
CLAUDE.md and a comment in output.go referred to a --result-type flag that
does not exist; CSV/XLSX come from query run's "resultType" body field.
agent-help's "some positionals take a NAME" note gains the other cases that
tripped a scripted sweep: delete-branch, labels, document labels, and the
membership-ID argument of users get-model-roles. The spec and --help already
describe each of these correctly; this is a cross-cutting reminder only.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ei8UYaG1bW5PJhk93EaqzA

@dspangendspangen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex says:

One minor documentation issue; no functional defects found.

[P3] Remove the remaining obsolete flag reference

cmd/omni/output_test.go:188 still says XLSX is selected with --result-type, although this PR establishes that the flag does not exist. Please update it to reference the query run body’s resultType field so the cleanup is complete.

The nested error extraction itself looks correct and preserves existing fallback behavior. GitHub CI reports both lint and test passing.

@ernestoongaro

Copy link
Copy Markdown
CollaboratorAuthor

Fixed in f926995output_test.go:188 was the last --result-type reference in the repo (grep is now clean); it now reads as the resultType body field like the others.

@ernestoongaro
ernestoongaro merged commit 43fe1a7 into mainAug 28, 2026
2 checks passed
@ernestoongaro
ernestoongaro deleted the fix/error-unwrap-and-docs branch August 28, 2026 14:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ernestoongaro@dspangen
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); fix(output): unwrap nested error objects; fix --result-type docs; agent-help name-vs-UUID examples by ernestoongaro · Pull Request #88 · exploreomni/cli · GitHub
Skip to content

fix(output): unwrap nested error objects; fix --result-type docs; agent-help name-vs-UUID examples - #88

Merged
ernestoongaro merged 2 commits into
mainfrom
fix/error-unwrap-and-docs
Aug 28, 2026
Merged

fix(output): unwrap nested error objects; fix --result-type docs; agent-help name-vs-UUID examples#88
ernestoongaro merged 2 commits into
mainfrom
fix/error-unwrap-and-docs

Conversation

@ernestoongaro

Copy link
Copy Markdown
Collaborator

Three small things from a full sweep of the CLI against a playground instance.

  1. Nested error bodies.{"error":{"code":403,"message":"Invalid bearer token"}} (what a bad token returns) was surfaced as the whole object re-serialised into "error". extractErrorDetail now descends one level into an object-valued detail/message/error key. Before/after:

    "error": "{\"error\":{\"code\":403,\"message\":\"Invalid bearer token\"}}"
    "error": "Invalid bearer token"
    

    Test added; fallback to the raw body is unchanged when no message is found.

  2. Docs.CLAUDE.md and an output.go comment referred to a --result-type flag that doesn't exist — CSV/XLSX come from query run's resultType body field.

  3. agent-help. The existing "some positionals take a NAME, not a UUID" note gains the other cases that tripped a scripted sweep (delete-branch, labels get, documents add-label, users get-model-roles <membership-id>). The spec and --help already describe each correctly; this is reinforcement only, easy to drop if unwanted.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ei8UYaG1bW5PJhk93EaqzA

…sult-type docs
Auth failures come back as {"error":{"code":403,"message":"Invalid bearer
token"}}. extractErrorDetail only accepted string values for detail/message/
error, so the whole object was re-serialised into the "error" field:
"error": "{\"error\":{\"code\":403,\"message\":\"Invalid bearer token\"}}".
Descend one level into an object-valued key and take its message/detail.
CLAUDE.md and a comment in output.go referred to a --result-type flag that
does not exist; CSV/XLSX come from query run's "resultType" body field.
agent-help's "some positionals take a NAME" note gains the other cases that
tripped a scripted sweep: delete-branch, labels, document labels, and the
membership-ID argument of users get-model-roles. The spec and --help already
describe each of these correctly; this is a cross-cutting reminder only.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ei8UYaG1bW5PJhk93EaqzA

@dspangendspangen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex says:

One minor documentation issue; no functional defects found.

[P3] Remove the remaining obsolete flag reference

cmd/omni/output_test.go:188 still says XLSX is selected with --result-type, although this PR establishes that the flag does not exist. Please update it to reference the query run body’s resultType field so the cleanup is complete.

The nested error extraction itself looks correct and preserves existing fallback behavior. GitHub CI reports both lint and test passing.

@ernestoongaro

Copy link
Copy Markdown
CollaboratorAuthor

Fixed in f926995output_test.go:188 was the last --result-type reference in the repo (grep is now clean); it now reads as the resultType body field like the others.

@ernestoongaro
ernestoongaro merged commit 43fe1a7 into mainAug 28, 2026
2 checks passed
@ernestoongaro
ernestoongaro deleted the fix/error-unwrap-and-docs branch August 28, 2026 14:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@ernestoongaro@dspangen