Uh oh!
There was an error while loading. Please reload this page.
Fix Japanese tokenizer URL handling - #14029
Open
bhushanasati25 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#13928.
Description
The Sudachi-backed Japanese tokenizer now protects URL spans before tokenizing the surrounding text, so URLs such as
https://example.com/jpstay as one token in Japanese sentences. The tokenizer uses spaCy's shared URL matcher for validation, preservesdoc.text_with_ws, and marks the resulting token with the normal lexicalLIKE_URLattribute.Types of change
Bug fix.
Tests
python -m pytest -q spacy/tests/lang/ja/test_tokenizer.py -k keeps_urlspython -m pytest -q spacy/tests/lang/ja/test_tokenizer.py -k 'not sub_tokens'python -m ruff format spacy/lang/ja/__init__.py spacy/tests/lang/ja/test_tokenizer.py --checkpython -m ruff check spacy/lang/ja/__init__.py spacy/tests/lang/ja/test_tokenizer.py --select Igit diff --checkNote:
python -m pytest -q spacy/tests/lang/ja/test_tokenizer.pyfails one existingtest_ja_tokenizer_sub_tokensexpectation with the currentsudachidict_core==20260723, where the first two subtoken entries are[[ ]]instead ofNone. The new URL regression passes.Checklist