Skip to content

move contributing and collaboration guide to .github - #10

Merged
wesleytodd merged 11 commits into
expressjs:masterfrom
bjohansebas:add-contributing
May 21, 2025
Merged

move contributing and collaboration guide to .github#10
wesleytodd merged 11 commits into
expressjs:masterfrom
bjohansebas:add-contributing

Conversation

@bjohansebas

@bjohansebasbjohansebas commented Nov 15, 2024

Copy link
Copy Markdown
Member

This is part of adding the documentation that can be inherited from this repository.

Port of #18

See also expressjs/discussions#353

@bjohansebas

Copy link
Copy Markdown
MemberAuthor

cc: @expressjs/express-tc

@bjohansebas

This comment was marked as outdated.

@wesleytoddwesleytodd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont like that added complexity of the admin repo. I was thinking we should make the .github repo the source for all we can. Honestly the name of the repo doesn't really matter as long as the docs are in the right place and the links are all correct.

My main concern with this current form is that we dont have a good concept in here of the difference between contributing to express vs all the other packages. I think we should keep this in a branch and open PRs against it here until we are satisfied. This whole consolidation effort was one of the main things I wanted to do soon, so let me just leave this comment here and circle back in a week or so.

@ctcpip

Copy link
Copy Markdown
Member

Agree with Wes. Frankly, we have a backlog of updating the contributing guide, as well as the security policy -- something we delayed doing until after the audit was complete and we were in 2025.

@bjohansebasbjohansebas changed the title docs: add contributing.mdmove contributing and collaboration guide to .githubMar 30, 2025
@bjohansebas

bjohansebas commented Mar 30, 2025

Copy link
Copy Markdown
MemberAuthor

see also expressjs/discussions#353

cc: @expressjs/express-tc

@wesleytoddwesleytodd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anything to pull this out of the express repo is good, but I do think the governence docs are not supported by GH to show in every repo, and also they apply for us to all three orgs, so we may be better off with that one in discussions than here.

@bjohansebas

Copy link
Copy Markdown
MemberAuthor

I do think the governence docs are not supported by GH to show in every repo

Yeah, even opening it on GitHub so they support this, since they show it as if they were going to do it.

https://github.com/orgs/community/discussions/155344

Comment threadCONTRIBUTING.md Outdated
Comment threadCONTRIBUTING.md Outdated
Comment threadCONTRIBUTING.md

@wesleytoddwesleytodd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am making a few edits to hopefully get this landed.

Comment threadCONTRIBUTING.md
Comment threadCONTRIBUTING.md Outdated
Comment threadCONTRIBUTING.md Outdated
Comment threadCONTRIBUTING.md Outdated
Comment threadCONTRIBUTING.md Outdated
@wesleytodd
wesleytodd merged commit 573cb2c into expressjs:masterMay 21, 2025
@bjohansebas
bjohansebas deleted the add-contributing branch May 22, 2025 02:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@bjohansebas@ctcpip@wesleytodd@UlisesGascon