Skip to content

Added support for brotli ('br') content-encoding - #403

Closed
danielgindi wants to merge 2 commits into
expressjs:masterfrom
danielgindi:feature/brotli
Closed

Added support for brotli ('br') content-encoding#403
danielgindi wants to merge 2 commits into
expressjs:masterfrom
danielgindi:feature/brotli

Conversation

@danielgindi

@danielgindidanielgindi commented Jul 10, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

@danielgindi
danielgindiforce-pushed the feature/brotli branch 6 times, most recently from 2015f22 to 5c8d15fCompareJuly 10, 2020 06:01
@danielgindidanielgindi mentioned this pull request Jul 10, 2020
Closed
dougwilson
dougwilson suggested changes Jul 10, 2020
View reviewed changes

@dougwilsondougwilson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs need to be updated to add the new encoding that is inflated and explain how the users know if it will be available or not.

Comment threadlib/read.js Outdated
Comment threadlib/read.js Outdated
Comment threadpackage.json Outdated
Comment threadtest/json.js Outdated
Comment threadtest/raw.js Outdated
Comment threadtest/urlencoded.js Outdated
Comment threadtest/text.js Outdated
Comment threadtest/json.js Outdated
Comment threadtest/raw.js Outdated
Comment threadtest/text.js Outdated
@danielgindi
danielgindiforce-pushed the feature/brotli branch 3 times, most recently from 8a297bb to a6dd921CompareJuly 10, 2020 13:34
dougwilson
dougwilson suggested changes Jul 10, 2020
View reviewed changes
Comment threadREADME.md Outdated
ways, for example the `foo` property may not be there or may not be a string,
and `toString` may not be a function and instead a string or other user input.

**Note** Brotli provides better and faster compression then gzip or deflate, but is supported only since Node.js versions v11.7.0 and v10.16.0.

@dougwilsondougwilsonJul 10, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please hard-wrap this line to match the width of the rest of the lines. In addition, since this module only ever decompresses, is this note about compression relevant? I would think that the information about version support should be along with the br support docs, otherwise users may not see it.

@danielgindidanielgindiJul 12, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I altered the note

@dougwilsondougwilsonJul 13, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please stop marking this as resolved when you didn't address all my comments or respond back with why you don't think you should address some part to have a discussion on it.

@danielgindidanielgindiJul 13, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did hard wrap this when resolving the original comment, and now this line does not even exist 😂
This is why it was hidden. It's marked as "outdated" automatically

@dougwilsondougwilsonJul 13, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would think that the information about version support should be along with the br support docs, otherwise users may not see it.

@dougwilsondougwilsonJul 13, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OMG please STOP
image

Comment threadREADME.md Outdated
Comment threadREADME.md Outdated
Comment threadREADME.md Outdated
Comment threadpackage.json Outdated
Comment threadlib/read.js Outdated
Comment threadtest/json.js Outdated
@danielgindi
danielgindiforce-pushed the feature/brotli branch 3 times, most recently from b995bfe to 6c80c9eCompareJuly 10, 2020 15:47
dougwilson
dougwilson suggested changes Jul 10, 2020
View reviewed changes
Comment threadREADME.md Outdated
Comment threadREADME.md Outdated
Comment threadREADME.md Outdated
Comment threadREADME.md Outdated
Comment threadpackage.json Outdated
@danielgindi

danielgindi commented Jul 11, 2020

Copy link
Copy Markdown
ContributorAuthor

@dougwilson Are we good to go? ;-)

@dougwilson

dougwilson commented Jul 11, 2020

Copy link
Copy Markdown
Contributor

No, it seems like since you keep force pushing it is closing out unresolved comments I made. Please make sure you have responded to all my outstanding requests and don't resolve them before you do or without commenting on them first :)

@dougwilson

dougwilson commented Jul 11, 2020

Copy link
Copy Markdown
Contributor

I just tried to unresolve a few but they still do not show. I will plan to re-review and remake those comments again next week. Have a good weekend.

@danielgindi

danielgindi commented Jul 11, 2020

Copy link
Copy Markdown
ContributorAuthor

I remember resolving them all, but please add any outstanding comments...

@dougwilson

dougwilson commented Jul 11, 2020

Copy link
Copy Markdown
Contributor

I was just able to get at least one of the unresolved ones to re-show up as unresolved again above.

@danielgindi

danielgindi commented Jul 13, 2020

Copy link
Copy Markdown
ContributorAuthor

I was just able to get at least one of the unresolved ones to re-show up as unresolved again above.

I addressed them all now. Improved the docs a bit.

dougwilson
dougwilson suggested changes Jul 13, 2020
View reviewed changes

@dougwilsondougwilson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still an unresolved comment.

@danielgindi

danielgindi commented Jul 13, 2020

Copy link
Copy Markdown
ContributorAuthor

There is still an unresolved comment.

It shows me that you "requested changes" but does not show any changes that were requested!

@dougwilson

dougwilson commented Jul 13, 2020

Copy link
Copy Markdown
Contributor

Hm, weird. Here is a link to it: #403 (comment)

@dougwilson

dougwilson commented Jul 13, 2020

Copy link
Copy Markdown
Contributor

It is clear this PR is quite a mess at this point, and things are getting resolved that are not resolved. Please open this PR again so we can restart the review process 🙏

@dougwilson

dougwilson commented Jul 13, 2020

Copy link
Copy Markdown
Contributor

Edit: to clarify, I closed this because it seems like the comments are getting resolved likely automatically, and so it's hard to keep track of what is and is not resolved at this point. I think a fresh PR and a new review with this current iteration of code would help a lot in getting this landed is all. If there was a way in GitHub for me to just erase all comments above or something to "reset" a PR that would be awesome, but unfortunately there is no such feature... :(

@danielgindidanielgindi mentioned this pull request Jul 13, 2020
Merged
@danielgindi

danielgindi commented Jul 13, 2020

Copy link
Copy Markdown
ContributorAuthor

Edit: to clarify, I closed this because it seems like the comments are getting resolved likely automatically, and so it's hard to keep track of what is and is not resolved at this point. I think a fresh PR and a new review with this current iteration of code would help a lot in getting this landed is all. If there was a way in GitHub for me to just erase all comments above or something to "reset" a PR that would be awesome, but unfortunately there is no such feature... :(

Okay, made a new one.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@dougwilsondougwilsondougwilson requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancementpr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@danielgindi@dougwilson