Skip to content

feat: support for brotli - #194

Merged
wesleytodd merged 36 commits into
expressjs:masterfrom
bjohansebas:feature/brotli
Jan 8, 2025
Merged

feat: support for brotli#194
wesleytodd merged 36 commits into
expressjs:masterfrom
bjohansebas:feature/brotli

Conversation

@bjohansebas

@bjohansebasbjohansebas commented Oct 19, 2024•
edited
Loading

Copy link
Copy Markdown
Member

The changes from #172 are brought in, with the exception of using the accept negotiation logic.

danielgindiand others added 18 commits July 10, 2020 12:47
@bjohansebas

bjohansebas commented Oct 19, 2024

Copy link
Copy Markdown
MemberAuthor

It should use accepts, so this PR is not ready yet, and I don't have the option to turn it into a draft. I will soon open a PR in accepts to be able to use this logic

@bjohansebasbjohansebas self-assigned this Oct 19, 2024
@UlisesGascon
UlisesGascon requested a review from a teamOctober 20, 2024 17:24
@bjohansebas
bjohansebas marked this pull request as draft October 22, 2024 21:07
@bjohansebasbjohansebas mentioned this pull request Oct 22, 2024
Closed
blakeembrey
blakeembrey approved these changes Oct 23, 2024
View reviewed changes
Comment threadencoding_negotiator.js Outdated
@bjohansebas
bjohansebas marked this pull request as ready for review October 24, 2024 00:17
@blakeembreyblakeembrey mentioned this pull request Oct 24, 2024
Merged
@bjohansebas

bjohansebas commented Dec 1, 2024

Copy link
Copy Markdown
MemberAuthor

I really don't think there are any more changes to be made here.

@bjohansebas

This comment was marked as outdated.

Sign in to view
@bjohansebas
bjohansebas marked this pull request as draft December 5, 2024 16:51
@bjohansebas
bjohansebas marked this pull request as ready for review December 5, 2024 19:13
nscuilla-godaddy
nscuilla-godaddy reviewed Dec 6, 2024
View reviewed changes
Comment threadindex.js Outdated
blakeembrey
blakeembrey reviewed Dec 6, 2024
View reviewed changes
Comment threadindex.js
This was referenced Dec 17, 2024
Closed
Closed
@Kle0s

Kle0s commented Dec 23, 2024

Copy link
Copy Markdown

@wesleytodd any chance you have the time to review it once again so it could be merged?

@kapilaggar

kapilaggar commented Dec 29, 2024

Copy link
Copy Markdown

@bjohansebas@blakeembrey any idea when this PR will be merged and new version will be released?

@github-actionsgithub-actionsBot mentioned this pull request Dec 31, 2024
Closed
wesleytodd
wesleytodd approved these changes Jan 8, 2025
View reviewed changes

@wesleytoddwesleytodd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Lets merge and I will add this to the list of thing to prepare releases for in the next few weeks.

@wesleytodd
wesleytodd merged commit d272132 into expressjs:masterJan 8, 2025
@bjohansebas
bjohansebas deleted the feature/brotli branch January 8, 2025 20:38
@bjohansebas

bjohansebas commented Jan 8, 2025

Copy link
Copy Markdown
MemberAuthor

Thanks to everyone who made this possible

This was referenced Jan 8, 2025
Closed
Merged
@pratikborsadiya

pratikborsadiya commented Mar 5, 2025

Copy link
Copy Markdown

@nicksrandall@danielgindi@bjohansebas This feature will save a huge chunk of the overall internet data transfers thanks to the widespread use of Express and 20 million weekly downloads of this package. Kudos for the efforts you've put in to enable this 🎉

@bjohansebasbjohansebas mentioned this pull request May 11, 2025
Merged
13 tasks
@nobodysfoolnobodysfool mentioned this pull request Jul 18, 2025
Merged
@n-deringn-dering mentioned this pull request Jul 19, 2025
Open
@coderabbitaicoderabbitaiBot mentioned this pull request Apr 14, 2026
Merged
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeembreyblakeembreyblakeembrey approved these changes
@wesleytoddwesleytoddwesleytodd approved these changes
@UlisesGasconUlisesGasconAwaiting requested review from UlisesGascon
+1 more reviewer
@nscuilla-godaddynscuilla-godaddynscuilla-godaddy left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

@bjohansebasbjohansebas

Labels

semver-minortc agenda

Projects

None yet

Milestone

1.8.0

Development

Successfully merging this pull request may close these issues.

12 participants

@bjohansebas@sardeeplakhera@Fonger@Kle0s@kapilaggar@pratikborsadiya@wesleytodd@blakeembrey@nscuilla-godaddy@danielgindi@nicksrandall@UlisesGascon