refactor: simplify encoding negotiation logic

[bjohansebas]

I have found a better way to handle the enforce encoding

[wesleytodd]

This kind of simplification is what I was thinking of when I was commenting in the original PR, but I think it can be done without mocking the request object. Let me know if I am missing something as I didn't do much more than read this PR to ensure that would work.

[bjohansebas]

I forgot about the legacy support for Node.js :c

[wesleytodd]

Yeah, I like this a lot better. We should see about getting a few more eyes on it, but seems like a great improvement to land before we publish.

[IamLizu]

Hey @bjohansebas 👋

This looks clean to me. However, before pressing the approve thingy I need to clear a confusion. Previously it would apply gzip when enforceEncoding was *. But now, it doesn't compress at all on *.

It appears that we are introducing a huge change in the behavior of compression.

While I am okay with the change, I request a reference to an ADR that propose (accepted) / state in behavior change. Or perhaps it was agreed in a meeting? Sorry, I am still unable to attend the meetings.

[bjohansebas]

@IamLizu It is not really considered a breaking change yet since it has not been released to npm, so this change can still be made.

All the discussion has been offline, as you can see in the comments on this PR and the previous one.

[IamLizu]

Thanks for clarifying! I went through the comments on this PR (sorry, missing the reference for previous one), but I didn’t see anything about the behavior change for enforceEncoding with *.

I’m totally on board with the direction of the change, but since it’s a pretty big shift in behavior, it’d be super helpful to have it documented somewhere—maybe an ADR or even just a quick summary here in the thread. That way, we have something to point to later, especially for folks like me who weren’t part of the offline discussions.

What do you think?

[wesleytodd]

Just to close the loop: #191

This PR is where the * value was added, and while it was merged it was never published. This change just means the new option will not support * as an alias for gzip and you will need to pass that explicitly.

[IamLizu]

Oh, this makes sense now. Thanks for clearing it up @wesleytodd 👍