Skip to content

Throw TypeError if argument passed to res.status is null or undefined - #3111

Closed
Shastel wants to merge 2 commits into
expressjs:5.xfrom
Shastel:fix/#2795
Closed

Throw TypeError if argument passed to res.status is null or undefined#3111
Shastel wants to merge 2 commits into
expressjs:5.xfrom
Shastel:fix/#2795

Conversation

@Shastel

Copy link
Copy Markdown

It's fix for #2795

@dougwilson

Copy link
Copy Markdown
Contributor

Hi @Shastel , thanks for the pull request! I see in the issue you linked, it was said that #2797 is made to fix that issue. Is this pull request a duplicate of #2797 ? If not, in what ways does it differ?

@dougwilsondougwilson self-assigned this Oct 26, 2016
@Shastel

Copy link
Copy Markdown
Author

Hi @dougwilson, It's not a duplicate, but generally it's almost same as #2797 . But that pr has not any progress almost year

@dougwilson

Copy link
Copy Markdown
Contributor

Hi @Shastel, that PR is just pending merge into 5.x. Unless there is something you feel is wrong with it, we have full intention on merging that into 5.x. I do appreciate you making the pull request, but I don't want to disregard that user's PR and instead use this one unless there is something different about this one.

@dougwilson

Copy link
Copy Markdown
Contributor

To summarize, I can use this one over the other, but I wasn't aware of anything wrong with the other. If it's not a duplicate and there is something different, please explain the differences so we can understand which one to accept. Otherwise, we'll default to the one that came first is all I'm saying.

@Shastel

Copy link
Copy Markdown
Author

My pr hasn't unnecessary else statement.
And also we also should ask @joshuacaron about any progress

@dougwilson

Copy link
Copy Markdown
Contributor

And also we also should ask @joshuacaron about any progress

Progress of what?

@Shastel

Copy link
Copy Markdown
Author

@dougwilson sorry, i have misunderstanding with flow.
So if from yours point of view difference between pr's is not critical we should close my pr.

@dougwilson

Copy link
Copy Markdown
Contributor

I can use this one over the other, but I wasn't aware of anything wrong with the other. If it's not a duplicate and there is something different, please explain the differences so we can understand which one to accept. Otherwise, we'll default to the one that came first is all I'm saying.

@dougwilsondougwilson mentioned this pull request Jan 29, 2017
39 tasks
@dougwilsondougwilson added this to the 4.17 milestone Oct 27, 2018
@dougwilsondougwilson mentioned this pull request Oct 27, 2018
23 tasks
dougwilson pushed a commit that referenced this pull request Oct 27, 2018
@ShastelShastel closed this Nov 27, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Shastel@dougwilson