Uh oh!
There was an error while loading. Please reload this page.
Throw TypeError if argument passed to res.status is null or undefined - #3111
Throw TypeError if argument passed to res.status is null or undefined#3111Shastel wants to merge 2 commits into
Conversation
dougwilson
commented
Oct 26, 2016
Shastel
commented
Oct 26, 2016
Hi @dougwilson, It's not a duplicate, but generally it's almost same as #2797 . But that pr has not any progress almost year |
dougwilson
commented
Oct 26, 2016
Hi @Shastel, that PR is just pending merge into 5.x. Unless there is something you feel is wrong with it, we have full intention on merging that into 5.x. I do appreciate you making the pull request, but I don't want to disregard that user's PR and instead use this one unless there is something different about this one. |
dougwilson
commented
Oct 26, 2016
To summarize, I can use this one over the other, but I wasn't aware of anything wrong with the other. If it's not a duplicate and there is something different, please explain the differences so we can understand which one to accept. Otherwise, we'll default to the one that came first is all I'm saying. |
Shastel
commented
Oct 26, 2016
My pr hasn't unnecessary |
dougwilson
commented
Oct 26, 2016
Progress of what? |
Shastel
commented
Oct 26, 2016
@dougwilson sorry, i have misunderstanding with flow. |
dougwilson
commented
Oct 26, 2016
I can use this one over the other, but I wasn't aware of anything wrong with the other. If it's not a duplicate and there is something different, please explain the differences so we can understand which one to accept. Otherwise, we'll default to the one that came first is all I'm saying. |
It's fix for #2795