Uh oh!
There was an error while loading. Please reload this page.
Update docs - #3836
Conversation
wesleytodd
commented
Jan 4, 2019
Hey @jamesgeorge007. I feel like we discussed badges at some point and decided to use the badge board for these? Maybe it was in this one? #3710 |
dougwilson
commented
Jan 4, 2019
Yea, I'm iffy on adding a badge, of which a lot of those points are in what @wesleytodd linked to. But also I leaned that there are quite often new users who don't even know what "PR" stands for and I had to explain. I think if it's to be for users who don't think they can make a pull request in github already, they are likely in this group, so the PR badge is just going to go over their head. Perhaps instead of a badge, there should just be a contributing section added to the readme? It could just have a basic blurb about making one and have the link to contributing like this badge does. |
@wesleytodd@dougwilson Well if that's the case, shall I proceed with adding contributing guidelines section to the
|
dougwilson
commented
Jan 4, 2019
@jamesgeorge007 that Twitter account does not belong to the express project. |
removes PR welcoming badge
jamesgeorge007
commented
Jan 5, 2019
@dougwilson Removed the badge and added contributing guidelines section as you suggested. |
wesleytodd
commented
Jan 5, 2019
Two things:
|
@wesleytodd@dougwilson I had to close this as part of switching to another branch. |
wesleytodd
commented
Jan 7, 2019
It is fine to open a new PR but also if you are interested, you can use |
jamesgeorge007
commented
Jan 11, 2019
@wesleytodd Check out this stack-overflow discussion |
I think it is a good idea to have a badge welcoming pull requests pointing to the
contributing.mdfile 🤔