Uh oh!
There was an error while loading. Please reload this page.
chore(travis) add node 12 - #3946
Merged
Merged
Conversation
dougwilson
suggested changes
Apr 30, 2019
dougwilson
left a comment
Contributor
There was a problem hiding this comment.
Please update the appveyor.yml as well 👍
dougwilson
commented
May 9, 2019
Contributor
zuohuadong
commented
May 10, 2019
Author
Sorry, I didn't see it before. |
zuohuadong
commented
May 10, 2019
Author
|
zuohuadong
commented
May 10, 2019
Author
Should we remove some versions that are no longer officially supported by node.js? |
LinusU
commented
May 10, 2019
Member
We can only remove support for older Node.js runtimes in a breaking change, so that will have to happen on the 5.x branch... |
dougwilson
approved these changes
May 16, 2019
dougwilson
commented
May 16, 2019
Contributor
I re-targeted the PR to the 4.17 branch and only 12 was not covered, so just updated the PR to be adding Node.js 12. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.