Skip to content

examples: defend from xss - #4119

Merged
dougwilson merged 1 commit into
expressjs:masterfrom
KoyamaSohei:patch-2
Mar 25, 2020
Merged

examples: defend from xss#4119
dougwilson merged 1 commit into
expressjs:masterfrom
KoyamaSohei:patch-2

Conversation

@KoyamaSohei

Copy link
Copy Markdown
Contributor

fix: #3992

@KoyamaSoheiKoyamaSohei changed the title examples: defend xssexamples: defend from xssDec 13, 2019
@KoyamaSohei

Copy link
Copy Markdown
ContributorAuthor

@dougwilson
I would like to ask for review when you are not busy, thanks!

@UlisesGasconUlisesGascon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KoyamaSohei thanks for this PR!

LGTM ❤️

@UlisesGascon

Copy link
Copy Markdown
Member

@dougwilson should be merge it? :-)

@dougwilson

Copy link
Copy Markdown
Contributor

I just rebased it and changed to escape html lib last night. Plan to get it merged today, yes. CI was still running when I went to sleep.

@dougwilson

Copy link
Copy Markdown
Contributor

It looks like as of this morning, Travis CI is no longer connected to any of our repositories; I am investigating.

@dougwilsondougwilson self-assigned this Mar 25, 2020
@dougwilson
dougwilson merged commit 323a389 into expressjs:masterMar 25, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

XSS in examples

3 participants

@KoyamaSohei@UlisesGascon@dougwilson