Skip to content

Update CI - #4574

Merged
dougwilson merged 3 commits into
expressjs:masterfrom
aravindvnair99:testBench-upgrade
Aug 15, 2021
Merged

Update CI#4574
dougwilson merged 3 commits into
expressjs:masterfrom
aravindvnair99:testBench-upgrade

Conversation

@aravindvnair99

Copy link
Copy Markdown
Member
  • Update 12 series to Node.js@12.22
  • Update 10 series to Node.js@10.24
  • Fix missing Node.js@8.17 in AppVeyor (Travis CI was using 8.17 but AppVeyor was using 8.16)

Signed-off-by: Aravind Nair 22199259+aravindvnair99@users.noreply.github.com

@elidoran

Copy link
Copy Markdown

Why not add v14.17.0 and v16.1.0 and set the nightly to v17?

@aravindvnair99

aravindvnair99 commented May 14, 2021

Copy link
Copy Markdown
MemberAuthor

Why not add v14.17.0 and v16.1.0 and set the nightly to v17?

@elidoran 14.x is there in #4338. Last time I checked with 16, the build failed.

@dougwilson should I add 15 and 16?

Also my intention of this PR was to update existing CI and not upgrade. And also to fix an inconsistency.

@dougwilsondougwilson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I rebased and moved the Travis CI changes to GitHub Actions.

@dougwilson
dougwilson merged commit 06d1175 into expressjs:masterAug 15, 2021
@aravindvnair99
aravindvnair99 deleted the testBench-upgrade branch August 15, 2021 06:34
nevilm-lt pushed a commit to nevilm-lt/express that referenced this pull request Mar 1, 2022
nevilm-lt pushed a commit to nevilm-lt/express that referenced this pull request Apr 22, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@aravindvnair99@elidoran@dougwilson@3imed-jaberi@ssyrota