Uh oh!
There was an error while loading. Please reload this page.
Ignore settings on Object.prototype - #4803
Merged
dougwilson merged 1 commit intoFeb 21, 2022
Merged
Conversation
EvanHahn
commented
Feb 3, 2022
ContributorAuthor
There was a problem hiding this comment.
This change isn't strictly related, but I figured we could use the new utility. Happy to revert.
EvanHahn
commented
Feb 12, 2022
ContributorAuthor
No rush on my end, but let me know if you'd like me to do anything with this PR. |
dougwilsonforce-pushed
the
ignore-settings-on-object-prototype
branch
from
February 19, 2022 05:12
5d0ff99 to
99043f5Comparedougwilsonforce-pushed
the
ignore-settings-on-object-prototype
branch
from
February 21, 2022 01:06
99043f5 to
2ddae30Comparedougwilson
approved these changes
Feb 21, 2022
dougwilson
left a comment
Contributor
There was a problem hiding this comment.
thank you! i did end up removing the utils thing since we eventually want to get rid of utils and the only thing it was shared with, the router, was removed in 5.x anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before:
After:
See #4802 for more details.