Uh oh!
There was an error while loading. Please reload this page.
Correctly invoke async router callback asynchronously - #4891
Conversation
dougwilson
left a comment
There was a problem hiding this comment.
Thanks! Please add a test case or leave in the pr a demo of the issue and we can make it in to a test case.
lqqyt2423
commented
Apr 13, 2022
@dougwilson Please see the new commit |
dougwilson
commented
Apr 13, 2022
Great, thank you! Would you be willing to open the same PR over at https://github.com/pillarjs/router ? |
| } | ||
| // max sync stack | ||
| if (++sync > 100) { |
There was a problem hiding this comment.
Without looking at the current v8 stack frames, there is no way to know if you still have 100 frames left to use. Also params will add/remove to how many frames are used in each iteration, I wouldn't think. How did you come up with the number 100 for this?
lqqyt2423
commented
Apr 14, 2022
@dougwilson router repo already fixed it: pillarjs/router@e96ebf5 I have a new commit to fix stack overflow with a large sync stack: 538a789 |
dougwilson
commented
Apr 14, 2022
Ah, I guess we didn't port that over, lol! Thanks for pointing that out. I'll port that commit over to 4.18 🎉 |
Sometimes this error occurs:
RangeError: Maximum call stack size exceeded
This pull request can fix the error.