Uh oh!
There was an error while loading. Please reload this page.
update Node.js version 16.x, 18.x, 19.x and add 20.x - #5190
Conversation
rubiin
left a comment
There was a problem hiding this comment.
update to the latest lts which is 18.17.1 as it fixes some CVEs
There was a problem hiding this comment.
Looks good. Also I was wondering why are we running tests for all available node versions. Most of them (below 14) have stopped receiving any kind of security updates and its most likely anyone is using them.
Removal of the prior deprecated versions would help speeding up the CI
85a1ff2 to
8dc9cd0Compare8dc9cd0 to
f519ad9Compare1d27450 to
b282698Comparesheplu
commented
Oct 29, 2023
@dougwilson I can't manually retrigger all the tests but it should be working fine for all versions |
UlisesGascon
left a comment
There was a problem hiding this comment.
LGTM! Seems like the CI issue can be resolved by re-running the CI
aravindvnair99
left a comment
There was a problem hiding this comment.
Something to consider - Do we really need to hardcode the minor values?
We originally didn't have them, but Node.js would keep releassing versions that would break our CI in the minor. Then CITGM was made to fix that, but I think they removed express so probably even more useful to keep them pinned still. It really stinks when ever people try and make PRs or we try to do releases when the CI is suddenly broken and then the time needs to be spent fixing that instead. I think most recent the CI broke in a minor 18.x release of Node.js bc they major bumped npm. Thankfully didn't break CI when that happened so could fix when the focus was on updating CI instead of on something else. It does have the added benefit too that bumping the minor forces a retest on that new Node.js, otherwise it will sit there until we change something unrelated. |
Update Matrix with Node.js version