Skip to content

chore: upgrade send to 1.0.0 - #5817

Closed
benmccann wants to merge 1 commit into
expressjs:5.0from
benmccann:patch-1
Closed

chore: upgrade send to 1.0.0#5817
benmccann wants to merge 1 commit into
expressjs:5.0from
benmccann:patch-1

Conversation

@benmccann

@benmccannbenmccann commented Aug 8, 2024

Copy link
Copy Markdown

Why don't you use ^ anywhere and why do only some have ~? By pinning all these versions you prevent dependency deduping. There are two versions of send in the dependency tree, which makes the dependency tree much larger: https://npmgraph.js.org/?q=express@5.0.0-beta.3

@wesleytodd

Copy link
Copy Markdown
Member

Why don't you use ^ anywhere and why do only some have ~?

When v4 was released some npm versions were still in use which did not support ^ IIRC. Anyway, it was so long ago it is not applicable anymore, just a matter of getting things updated. And yes, we are well aware of the issues around deduping.

There are two versions of send in the dependency tree

In the v5 branch, the work to update all the dependencies is ongoing. In this case, it is already covered in #5786

Thanks for the PR, but I am going to close it in favor of the already exiting one.

@benmccann

Copy link
Copy Markdown
Author

Thanks! Sorry I missed that there was an already open PR for this!

@benmccann
benmccann deleted the patch-1 branch August 8, 2024 17:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@benmccann@wesleytodd