Uh oh!
There was an error while loading. Please reload this page.
Remove Object.setPrototypeOf polyfill - #6081
Merged
Merged
Conversation
UlisesGascon
approved these changes
Oct 21, 2024
UlisesGascon
left a comment
Member
There was a problem hiding this comment.
LGTM! Thanks for this PR @Phillip9587!
bjohansebas
approved these changes
Oct 21, 2024
bjohansebas
left a comment
Member
There was a problem hiding this comment.
Should this change be reflected in the history?
Phillip9587force-pushed
the
remove-setprototypeof
branch
from
October 22, 2024 07:47
86f999e to
bcab127CompareUlisesGascon
approved these changes
Oct 22, 2024
Closed
Merged
This was referenced Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
Object.setPrototypeOfpolyfill, which is no longer needed since Express now requires Node.js v18 as the minimum supported version. All existing tests should pass, as this change only impacts older Node versions no longer supported.