Skip to content

deps: upgrade supertest - #6112

Closed
agungjati wants to merge 3 commits into
expressjs:masterfrom
agungjati:master-fix/upgrade-supertest
Closed

deps: upgrade supertest#6112
agungjati wants to merge 3 commits into
expressjs:masterfrom
agungjati:master-fix/upgrade-supertest

Conversation

@agungjati

@agungjatiagungjati commented Oct 31, 2024•
edited by UlisesGascon
Loading

Copy link
Copy Markdown
Contributor

@agungjatiagungjati mentioned this pull request Oct 31, 2024
Closed
@UlisesGasconUlisesGascon changed the title master-fix/upgrade-supertestdeps: upgrade supertestNov 1, 2024
@UlisesGasconUlisesGascon self-assigned this Nov 1, 2024
@bjohansebas

bjohansebas commented Dec 8, 2024

Copy link
Copy Markdown
Member

There is already a version 7.

UlisesGascon
UlisesGascon reviewed Dec 20, 2024
View reviewed changes
Comment threadpackage.json
@UlisesGascon

UlisesGascon commented Dec 20, 2024

Copy link
Copy Markdown
Member

@bjohansebas I was trying to target 7.0.0, seems like we will need to some work, based on the CI results

UlisesGascon
UlisesGascon reviewed Dec 20, 2024
View reviewed changes
Comment threadpackage.json Outdated
UlisesGascon
UlisesGascon approved these changes Dec 20, 2024
View reviewed changes

@UlisesGasconUlisesGascon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 6.3.4 is stable in the CI

wesleytodd
wesleytodd reviewed Jan 8, 2025
View reviewed changes
Comment threadpackage.json
"nyc": "15.1.0",
"pbkdf2-password": "1.2.1",
"supertest": "6.3.0",
"supertest": "6.3.4",

@wesleytoddwesleytoddJan 8, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we just unpin this (^)? I thought we agreed to just unpin all these as we touched them?

sheplu
sheplu approved these changes Jan 9, 2025
View reviewed changes

@sheplusheplu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but as @wesleytodd said can we ^ the deps but also maybe not update them all one by one

wesleytodd pushed a commit that referenced this pull request Feb 13, 2025
@agungjati@wesleytodd
fix (deps): update deps
af44fa3
fix(deps): mocha@^10.7.3 (closes#6121)
fix(deps): marked@^15.0.3 (closes#6120)
fix(deps): express-session@^1.18.1 (closes#6119)
fix(deps): ejs@^3.1.10 (closes#6117)
fix(deps): content-type@^1.0.5 (closes#6115)
fix(deps): connect-redis@^8.0.1 (closes#6114)
fix(deps): supertest@^7.0.0 (closes#6112)
@wesleytoddwesleytodd mentioned this pull request Feb 13, 2025
Merged
wesleytodd pushed a commit that referenced this pull request Feb 13, 2025
@agungjati@wesleytodd
fix (deps): update deps
37c4799
fix(deps): mocha@^10.7.3 (closes#6121)
fix(deps): marked@^15.0.3 (closes#6120)
fix(deps): express-session@^1.18.1 (closes#6119)
fix(deps): ejs@^3.1.10 (closes#6117)
fix(deps): content-type@^1.0.5 (closes#6115)
fix(deps): connect-redis@^8.0.1 (closes#6114)
fix(deps): supertest@^6.3.4 (closes#6112)
@wesleytodd

wesleytodd commented Feb 13, 2025

Copy link
Copy Markdown
Member

I am nearly positive I tried this update and hit the same error a few months ago. I searched but couldnt find the pr/issue. IIRC there is a bug in newer versions of supertest which is why I didn't land this update for the first v5 release. I had forgotten about it, but ran into it again here: #6337

In the new PR I pinned it back to the 6 range.

@wesleytoddwesleytodd mentioned this pull request Feb 13, 2025
Open
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleytoddwesleytoddwesleytodd left review comments
@sheplusheplusheplu approved these changes
@UlisesGasconUlisesGasconUlisesGascon approved these changes
+1 more reviewer
@IamLizuIamLizuIamLizu approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@UlisesGasconUlisesGascon

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@agungjati@bjohansebas@UlisesGascon@wesleytodd@sheplu@IamLizu