Uh oh!
There was an error while loading. Please reload this page.
cleanup: remove unnecessary require for global Buffer - #6146
Merged
Conversation
bjohansebas
approved these changes
Nov 5, 2024
UlisesGascon
approved these changes
Nov 7, 2024
wesleytodd
approved these changes
Nov 15, 2024
wesleytodd
left a comment
Member
There was a problem hiding this comment.
Can we update the history.md file? Sorry for being pedantic, but until we automate it I want to make sure we dont miss something in the release notes on accident.
MemberAuthor
@wesleytodd Edit: I just read your comment on #6147 and #6176 and just added the entry |
The Buffer object is globally available in Node.js, so there is no need to explicitly require it.
Phillip9587force-pushed
the
remove-buffer-require
branch
from
November 15, 2024 16:08
842601c to
d246446Comparewesleytodd
commented
Nov 15, 2024
Member
Thanks! yeah we will be automating that, but I think there is some question still of how deep we want to go on the automation, so it has not happened yet. Just making sure we don't make a mistake by abandoning the process even if it is a bad process 😄 . |
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Buffer object is globally available in Node.js, so there is no need to explicitly require it.