Skip to content

refactor: improve readability - #6173

Merged
UlisesGascon merged 2 commits into
expressjs:masterfrom
sazk07:patch-1
Nov 27, 2024
Merged

refactor: improve readability#6173
UlisesGascon merged 2 commits into
expressjs:masterfrom
sazk07:patch-1

Conversation

@sazk07

@sazk07sazk07 commented Nov 12, 2024

Copy link
Copy Markdown
Contributor

Fix typo in condition check

@sazk07
Fix typo: Update index.js
c6f399c
Fix typo in condition check
wesleytodd
wesleytodd requested changes Nov 12, 2024
View reviewed changes
Comment threadexamples/params/index.js Outdated
@sazk07
Fix: separate assignment and condition check in Update index.js
00887b9
assignment was being done inside condition check leading to confusion in reading code.
@sazk07

sazk07 commented Nov 12, 2024

Copy link
Copy Markdown
ContributorAuthor

assignment inside condition check leading to confusion in reading code. Change proposed.

@sazk07sazk07 changed the title Fix typo: Update index.jsFix: separate assignment and condition check in Update index.jsNov 12, 2024
@sazk07sazk07 changed the title Fix: separate assignment and condition check in Update index.jsFix: separate assignment and condition check in index.jsNov 12, 2024
sazk07
sazk07 commented Nov 12, 2024
View reviewed changes

@sazk07sazk07 left a comment

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated

@UlisesGasconUlisesGascon changed the title Fix: separate assignment and condition check in index.jsrefactor: improve readabilityNov 27, 2024
@UlisesGascon
UlisesGascon merged commit e4a61bd into expressjs:masterNov 27, 2024
@UlisesGascon

UlisesGascon commented Nov 27, 2024

Copy link
Copy Markdown
Member

@sazk07 do you want to backport this to v4 branch too?

@sazk07

sazk07 commented Nov 27, 2024

Copy link
Copy Markdown
ContributorAuthor

@sazk07 do you want to backport this to v4 branch too?

@UlisesGascon PR made in v4 branch. pls check from your end.

@wesleytoddwesleytodd mentioned this pull request Dec 9, 2024
Merged
@bjohansebasbjohansebas mentioned this pull request Mar 15, 2025
Closed
@UlisesGasconUlisesGascon mentioned this pull request Mar 23, 2025
Closed
68 tasks
@wesleytoddwesleytodd mentioned this pull request Mar 28, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesleytoddwesleytoddwesleytodd approved these changes
@UlisesGasconUlisesGasconUlisesGascon approved these changes
@bjohansebasbjohansebasbjohansebas approved these changes
+1 more reviewer
@krzysdzkrzysdzkrzysdz left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sazk07@UlisesGascon@wesleytodd@krzysdz@bjohansebas