Skip to content

chore: replace methods dependency with standard library - #6196

Merged
UlisesGascon merged 1 commit into
expressjs:masterfrom
jonkoops:replace-methods
Jan 2, 2025
Merged

chore: replace methods dependency with standard library#6196
UlisesGascon merged 1 commit into
expressjs:masterfrom
jonkoops:replace-methods

Conversation

@jonkoops

Copy link
Copy Markdown
Contributor

Replaces the methods dependency with calls to the standard library of Node.js. Since methods is mostly a polyfill for require('node:http').METHODS in older versions of Node.js that are no longer supported this can be removed.

Works towards closing #4282

Signed-off-by: Jon Koops <jonkoops@gmail.com>

@bjohansebasbjohansebas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@3imed-jaberi3imed-jaberi left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we no longer support Node.js versions earlier than 18, we can proceed with this!

+1

@UlisesGasconUlisesGascon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@UlisesGasconUlisesGascon changed the title Replace methods dependency with standard librarychore: replace methods dependency with standard libraryJan 2, 2025
@UlisesGascon
UlisesGascon merged commit b11122b into expressjs:masterJan 2, 2025
@jonkoops
jonkoops deleted the replace-methods branch January 2, 2025 11:04
@bjohansebasbjohansebas mentioned this pull request Mar 15, 2025
@UlisesGasconUlisesGascon mentioned this pull request Mar 23, 2025
68 tasks
@wesleytoddwesleytodd mentioned this pull request Mar 28, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@jonkoops@UlisesGascon@IamLizu@3imed-jaberi@bjohansebas