Uh oh!
There was an error while loading. Please reload this page.
docs: clarify guidelines for becoming a committer - #6364
Merged
Conversation
wesleytodd
approved these changes
Mar 4, 2025
wesleytodd
left a comment
Member
There was a problem hiding this comment.
LGTM! I think we still leave room for interpretation here but that might be a good thing. This is for sure better wording than "trivial"!
UlisesGascon
approved these changes
Mar 4, 2025
ctcpip
reviewed
Mar 4, 2025
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Chris de Almeida <ctcpip@users.noreply.github.com>
ctcpip
approved these changes
Mar 4, 2025
Phillip9587
approved these changes
Mar 5, 2025
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Slack, a question arose about what 'trivial' means in these cases. Non-trivial things can be many different things, maybe this language would make it clearer, or if not, we can leave it as it is.