Skip to content

chore: ignore yarn.lock file and update example - #6588

Merged
UlisesGascon merged 2 commits into
expressjs:masterfrom
shivarm:allow-to-use-multiple-pkg-manager
Aug 20, 2025
Merged

chore: ignore yarn.lock file and update example#6588
UlisesGascon merged 2 commits into
expressjs:masterfrom
shivarm:allow-to-use-multiple-pkg-manager

Conversation

@shivarm

Copy link
Copy Markdown
Contributor

When I used yarn then yarn.lock generated, our existing .npmrc working for npm and pnpm but for yarn we have to delete it after install.

This will allow us to use above package manager without conflict of lock files

@bjohansebasbjohansebas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion here, since there's also devEngines and we could probably enforce using only npm.

@shivarm

shivarm commented Jun 25, 2025

Copy link
Copy Markdown
ContributorAuthor

I don't have a strong opinion here, since there's also devEngines and we could probably enforce using only npm.

I think devEngines will break the idea of using multiple packagemanager. But this will allow us to use any packagemanager since we are not pushing lockfile, so no conflicts.

@shivarm

Copy link
Copy Markdown
ContributorAuthor

This PR will not break anything, it will break when we were rely on lockfiles and we know pnpm and yarn both have their lockfiles but for npm and pnpm our configuration working, means lockfile not generating while dependencies install step, but for yarn it is not working.

@IamLizuIamLizu left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t have a strong opinion here either – ignoring yarn.lock to avoid lockfile conflicts when using Yarn makes sense if we want true multi–package-manager support.

We could also explore enforcing a single manager via devEngines as @bjohansebas said, but that’d be a more restrictive approach.

Given that this change is harmless for npm/pnpm users and just skips committing the Yarn lockfile, I’m happy to approve.

@shivarm

Copy link
Copy Markdown
ContributorAuthor

We could also explore enforcing a single manager via devEngines as @bjohansebas said, but that’d be a more restrictive approach.

Yes, this will restrict the idea

@shivarm

Copy link
Copy Markdown
ContributorAuthor

@UlisesGascon WDYT?

@shivarm
shivarmforce-pushed the allow-to-use-multiple-pkg-manager branch from fe26fd0 to 4c072b4CompareJuly 15, 2025 13:42
@shivarm
shivarmforce-pushed the allow-to-use-multiple-pkg-manager branch from 4c072b4 to 5ef70dcCompareAugust 13, 2025 13:36

@UlisesGasconUlisesGascon left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@UlisesGascon

Copy link
Copy Markdown
Member

I will merge this PR next week 👍

@UlisesGasconUlisesGascon self-assigned this Aug 20, 2025
Comment threadReadme.md Outdated
@UlisesGascon
UlisesGascon merged commit d9a62f9 into expressjs:masterAug 20, 2025
24 of 26 checks passed
@shivarm
shivarm deleted the allow-to-use-multiple-pkg-manager branch August 21, 2025 07:19
@UlisesGasconUlisesGascon mentioned this pull request Nov 25, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@shivarm@UlisesGascon@IamLizu@bjohansebas