Skip to content

Add CONTRIBUTING.md and CODE_OF_CONDUCT.md files - #6604

Closed
RaginiSharma01 wants to merge 5 commits into
expressjs:masterfrom
RaginiSharma01:master
Closed

Add CONTRIBUTING.md and CODE_OF_CONDUCT.md files#6604
RaginiSharma01 wants to merge 5 commits into
expressjs:masterfrom
RaginiSharma01:master

Conversation

@RaginiSharma01

Copy link
Copy Markdown

No description provided.

@RaginiSharma01

Copy link
Copy Markdown
Author

I have added the contributing.d and code_of_conduct.md

@krzysdz

Copy link
Copy Markdown
Contributor

The links should be updated like @ShubhamOulkar did in #6601 and point to files from expressjs/.github repository (see #6593 (comment)). Additionally, the link to the Code of Conduct is given at the bottom of README and that's where it should be changed (it's a collapsed reference link):

[Code of Conduct]: https://github.com/expressjs/express/blob/master/Code-Of-Conduct.md

@RaginiSharma01RaginiSharma01 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i have made changes . and added the code of conduct

Comment threadpackage.json

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please keep the PR focused, this change is unnecessary

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be better if you created a new PR, since this change could block the goal of the current one, which is to bring that file back.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaginiSharma01 This change is still here. Please remove the changes you made here, they don't belong in this PR

Comment threadcode_of_conduct.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The content of this file should say something like "The code of conduct is located in https://github.com/expressjs/.github/blob/HEAD/CODE_OF_CONDUCT.md" rather than bringing back the full content, since we don’t want to maintain two versions in different places.

Comment threadContributing.md Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjohansebas

Copy link
Copy Markdown
Member

@RaginiSharma01 Could you please make the changes I asked for?

@RaginiSharma01RaginiSharma01 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjohansebas now check i have updated the links and deleted the files for code of conduct and contributing md

Comment threadReadme.md

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here are already being handled by #6601

@bjohansebas

Copy link
Copy Markdown
Member

This PR made sense because it was bringing back the important files, but now it's just another repeated PR of #6601. Could you please create the Code_of_Conduct.md and Contributing.md files, with content stating that they have been moved to a specific location?

@RaginiSharma01

RaginiSharma01 commented Jul 14, 2025

Copy link
Copy Markdown
Author

@bjohansebas so i have to create those files again right , replace the files with links https://github.com/expressjs/.github/blob/HEAD/CODE_OF_CONDUCT.md

@bjohansebas

Copy link
Copy Markdown
Member

Unless GitHub is broken, those files are not showing up for me

@SauravKhare

Copy link
Copy Markdown

@bjohansebas this is the same README.md PR scam. Don't even waste your time reviewing.

@bjohansebas

Copy link
Copy Markdown
Member

I’m going to close this since there hasn’t been any activity and most of the links have already been updated. If any are still missing, please report it

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@RaginiSharma01@krzysdz@bjohansebas@SauravKhare