Uh oh!
There was an error while loading. Please reload this page.
fix(res): throw error when res.redirect(undefined) is called - #6942
Closed
BOXER78 wants to merge 3 commits into
Closed
fix(res): throw error when res.redirect(undefined) is called#6942BOXER78 wants to merge 3 commits into
BOXER78 wants to merge 3 commits into
Conversation
bjohansebas
commented
Dec 11, 2025
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling res.redirect(undefined) currently sends a 302 response with
Location: undefined,resulting in an invalid redirect header.
This PR throws a TypeError when the URL argument is missing, consistent with the deprecation
warning ("Provide a url argument") and prevents malformed headers.
Improved the redirect tests to match Express behavior more accurately:
The updated test suite does not change redirect behavior, but validates it more accurately and prevents future regressions.
Fixes#6941