Skip to content

Fix downloads route error handling - #7120

Closed
nmurrell07 wants to merge 1 commit into
expressjs:masterfrom
nmurrell07:fix-downloads-bug
Closed

Fix downloads route error handling#7120
nmurrell07 wants to merge 1 commit into
expressjs:masterfrom
nmurrell07:fix-downloads-bug

Conversation

@nmurrell07

Copy link
Copy Markdown

Corrected usage of req.params.file in downloads example.

@krzysdz

Copy link
Copy Markdown
Contributor

The file parameter is a wildcard parameter, which means that in req.params it is an array (in Express 5). For more information see #5885, pillarjs/router#117 or the documentation.

P.S. The commit shows as authored by "virtual machine".

@nmurrell07

Copy link
Copy Markdown
Author

Submit from a VM. I will review feedback and resubmit.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@nmurrell07@krzysdz