Uh oh!
There was an error while loading. Please reload this page.
fix(response): throw TypeError on invalid redirect url/status - #7323
Closed
Dasmat13 wants to merge 1 commit into
Closed
fix(response): throw TypeError on invalid redirect url/status#7323Dasmat13 wants to merge 1 commit into
Dasmat13 wants to merge 1 commit into
Conversation
Fixesexpressjs#6941 Signed-off-by: Dasmat13 <mey37056@gmail.com>
krzysdz
commented
Jun 20, 2026
Contributor
Duplicate of#6404 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#6941. When
res.redirect(undefined)is called, it previously logged a deprecation warning and then proceeded to send an invalidLocation: undefinedheader. This commit changes the behavior to throw aTypeErrorimmediately if the url is undefined, null, or not a string. It also throws aTypeErrorif the status is not a number. Tests have been added to verify this behavior.