Uh oh!
There was an error while loading. Please reload this page.
Preserve unknown Content-Type values in res.set() - #7384
Closed
ShreyashShaurya wants to merge 1 commit into
Closed
Conversation
krzysdz
commented
Jul 18, 2026
Contributor
Duplicate of#7035 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
res.set('Content-Type', value)is called with an unknown content type,mime.contentType(value)returnsfalse. Express currently forwards thatvalue to
setHeader, resulting in aContent-Type: falseheader.This change preserves the original value when MIME lookup fails.
Changes
Content-Typevalues by falling back to the original input.Fixes#7034