refactor: enhance documentation navigation and modernize i18n structure by ShubhamOulkar · Pull Request #2252 · expressjs/expressjs.com

ShubhamOulkar · 2026-04-02T12:50:12Z

Refactored Breadcrumb component
Implemented content aware linking in buildBreadcrumbs (unlinked for docs, linked for API/Blog/Resources). ref
Abstracted documentation navigation logic from DocLayout.astro into DocBottomNav.
Improved PageTopbar responsiveness with a vertical stack layout on small screens.
Standardized aria-label across all navigation components for better accessibility.
Updated and reorganized all 10 UI translation JSON files to a nested schema.

netlify · 2026-04-02T12:50:17Z

✅ Deploy Preview for expressjscom-preview ready!

Name	Link
🔨 Latest commit	`48a3ed9`
🔍 Latest deploy log	https://app.netlify.com/projects/expressjscom-preview/deploys/69cf1e6f269a41000840a3dc
😎 Deploy Preview	https://deploy-preview-2252--expressjscom-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 99 (🟢 up 3 from production) Accessibility: 100 (🟢 up 13 from production) Best Practices: 100 (no change from production) SEO: 100 (🟢 up 6 from production) PWA: 80 (🟢 up 50 from production) View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

bjohansebas · 2026-04-03T00:59:06Z

Okay, I’ll review it right away, because after that I’ll start working on Crowdin

ShubhamOulkar · 2026-04-03T01:13:47Z

@bjohansebas fixing heading I will push in changes

…dings

bjohansebas · 2026-04-03T01:39:27Z

Why is it returning the #? It wants them because they’re already being generated from the layout—it’s intentional

ShubhamOulkar · 2026-04-03T01:41:49Z

+ items: [
+ { href: '/api/middleware/basicauth', label: 'basicAuth()' },
+ { href: '/api/middleware/bodyparser', label: 'bodyParser()' },
+ { href: '/api/middleware/compress', label: 'compress()' },


I am confused here.

Express 3 included middlewares; Express 4 removed them. We can’t remove them because they’re part of the 3.x API.

ShubhamOulkar · 2026-04-03T01:44:04Z

Why is it returning the #? It wants them because they’re already being generated from the layout—it’s intentional

Api pages were rendering two h1 headings, so I decided to align docs with api pages and remove h1 from DocsLayout.

bjohansebas · 2026-04-03T01:45:59Z

Api pages were rendering two h1 headings, so I decided to align docs with api pages and remove h1 from DocsLayout.

It’s the other way around—we should remove the #h1. It was intentional; I was planning to finish fixing that in another PR, but I didn’t get to it because I’m wrapping up some things in webpack.

This reverts commit 0a273d3.

ShubhamOulkar · 2026-04-03T01:55:07Z

I was planning to finish fixing that in another PR

OK, then you need to edit all API markdowns.

bjohansebas · 2026-04-03T01:57:31Z

OK, then you need to edit all API markdowns.

yep, but in other pr, please

ShubhamOulkar · 2026-04-03T02:04:27Z

OK, then you need to edit all API markdowns.
yep, but in other pr, please

But I dont understand why are you choosing more editing files over small docs files? At end we are rendering same headings as title. are you planning to change API headings? (property, methods)

bjohansebas

Next PRs will be follow-ups to this, I’ll be working on Crowdin

bjohansebas · 2026-04-03T02:11:11Z

Yes, I plan to improve how we present the API so that options and arguments are displayed more clearly—something similar to how it’s done in Node.js

ShubhamOulkar · 2026-04-03T02:34:51Z

great 🤗 please let me know whenever changes happen. It will be great experience to review/polish documentations

ShubhamOulkar requested a review from a team as a code owner April 2, 2026 12:50

ShubhamOulkar marked this pull request as draft April 2, 2026 12:50

ShubhamOulkar force-pushed the refactor branch from 82eb6e5 to 0faa816Compare April 2, 2026 12:53

ShubhamOulkar removed the request for review from a teamApril 2, 2026 12:54

ShubhamOulkar force-pushed the refactor branch from 9bfb228 to 7f3f0f2Compare April 2, 2026 14:38

ShubhamOulkar changed the title ~~WIP~~refactor: Enhance Documentation Navigation and Modernize i18n StructureApr 2, 2026

ShubhamOulkar changed the title ~~refactor: Enhance Documentation Navigation and Modernize i18n Structure~~refactor: enhance documentation navigation and modernize i18n structureApr 2, 2026

ShubhamOulkar self-assigned this Apr 2, 2026

ShubhamOulkar added 7 commits April 3, 2026 05:58

i18n labels
4d0c8cf

refactor(breadcrumbs): enhance linking logic and accessibility
e1a2fda

chore: abstract doc bottom navigation
2e41f1d

style(ui): refactor breadcrumbs and topbar for better mobile support
65f305a

fix(deps): add missing unist-util-visit package
5f1717e

add UI translations
a531d7e

lint
7f960ca

ShubhamOulkar force-pushed the refactor branch from 4c1be8b to 7f960caCompare April 3, 2026 00:29

ShubhamOulkar marked this pull request as ready for review April 3, 2026 00:29

fix ci
d03450e

bjohansebas added 2 commits April 2, 2026 20:07

fix linter
9197fd7

fix(api): add omitFrom property for req.method and req.get in apiMenu
800c9cb

bjohansebasand others added 4 commits April 2, 2026 20:28

add mising properties
d934291

feat(api): add middleware section to apiMenu
d8deff6

make heading consistant in the content
0a273d3

refactor: move DocBottomNav and standardize English documentation hea…
b38d11b
…dings

ShubhamOulkar commented Apr 3, 2026
View reviewed changes

bjohansebas added 2 commits April 2, 2026 20:47

refactor(api): rename menu item label from 'methods' to 'types'
4cb2ced

Revert "make heading consistant in the content"
48a3ed9
This reverts commit 0a273d3.

bjohansebas approved these changes Apr 3, 2026
View reviewed changes

bjohansebas merged commit b9b3b9c into expressjs:redesignApr 3, 2026
15 of 16 checks passed

ShubhamOulkar deleted the refactor branch April 3, 2026 02:14

bjohansebas mentioned this pull request Apr 4, 2026
chore: redesign in Astro #2169
Merged

Uh oh!

Uh oh!

Conversation

ShubhamOulkar commented Apr 2, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlifyBot commented Apr 2, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for expressjscom-preview ready!

Uh oh!

bjohansebas commented Apr 3, 2026

Uh oh!

ShubhamOulkar commented Apr 3, 2026

Uh oh!

bjohansebas commented Apr 3, 2026

Uh oh!

ShubhamOulkarApr 3, 2026

Choose a reason for hiding this comment

Uh oh!

bjohansebasApr 3, 2026

Choose a reason for hiding this comment

Uh oh!

ShubhamOulkar commented Apr 3, 2026

Uh oh!

bjohansebas commented Apr 3, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ShubhamOulkar commented Apr 3, 2026

Uh oh!

bjohansebas commented Apr 3, 2026

Uh oh!

ShubhamOulkar commented Apr 3, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bjohansebas left a comment

Choose a reason for hiding this comment

Uh oh!

bjohansebas commented Apr 3, 2026

Uh oh!

Uh oh!

ShubhamOulkar commented Apr 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ShubhamOulkar commented Apr 2, 2026•
edited
Loading

netlifyBot commented Apr 2, 2026•
edited
Loading

bjohansebas commented Apr 3, 2026•
edited
Loading

ShubhamOulkar commented Apr 3, 2026•
edited
Loading