Skip to content

ci: skip Orama Cloud sync for external PRs - #2297

Merged
bjohansebas merged 1 commit into
expressjs:gh-pagesfrom
krzysdz:fix-ci-in-forks
May 18, 2026
Merged

ci: skip Orama Cloud sync for external PRs#2297
bjohansebas merged 1 commit into
expressjs:gh-pagesfrom
krzysdz:fix-ci-in-forks

Conversation

@krzysdz

@krzysdzkrzysdz commented Apr 25, 2026

Copy link
Copy Markdown
Contributor

PRs coming from forks (and dependabot) do not have access to secrets, which are required for this job.

GitHub does not allow checking env or secrets in jobs.<id>.if (actions/runner#1138), so instead skip all steps separately.

Ref: #2169 (comment)

@krzysdz
krzysdz requested a review from a team as a code ownerApril 25, 2026 19:42
@netlify

netlifyBot commented Apr 25, 2026

Copy link
Copy Markdown

Deploy Preview for expressjscom-preview ready!

NameLink
🔨 Latest commitaf6244e
🔍 Latest deploy loghttps://app.netlify.com/projects/expressjscom-preview/deploys/69ed1d24c727410008653b83
😎 Deploy Previewhttps://deploy-preview-2297--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 100 (🟢 up 13 from production)
Best Practices: 100 (no change from production)
SEO: 100 (🟢 up 6 from production)
PWA: 80 (🟢 up 50 from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@krzysdz
krzysdz marked this pull request as draft April 25, 2026 19:45
PRs coming from forks (and dependabot) do not have access to secrets, which are required for this job. GitHub does not allow checking `env` or `secrets` in `jobs.<id>.if`, so instead we skip all steps.
@krzysdz
krzysdz marked this pull request as ready for review April 25, 2026 20:01
@krzysdzkrzysdz mentioned this pull request Apr 25, 2026
@krzysdzkrzysdz added the github_actions Pull requests that update GitHub Actions code label Apr 25, 2026
@bjohansebas
bjohansebas changed the base branch from redesign to gh-pagesMay 18, 2026 19:35
@bjohansebas
bjohansebas merged commit 7565c75 into expressjs:gh-pagesMay 18, 2026
12 of 14 checks passed
@krzysdz
krzysdz deleted the fix-ci-in-forks branch May 18, 2026 22:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actionsPull requests that update GitHub Actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@krzysdz@bjohansebas