Skip to content

chore: rewrite HTML tables in migrating-4.mdx to markdown - #2485

Merged
ShubhamOulkar merged 3 commits into
expressjs:mainfrom
krzysdz:scrollable-tables
Sep 3, 2026
Merged

chore: rewrite HTML tables in migrating-4.mdx to markdown#2485
ShubhamOulkar merged 3 commits into
expressjs:mainfrom
krzysdz:scrollable-tables

Conversation

@krzysdz

@krzysdzkrzysdz commented Aug 8, 2026

Copy link
Copy Markdown
Contributor

Tables in migrating-4.mdx are simple an have been rewritten using markdown syntax, which makes them work better with plugins (the HTML was missing <thead> and <tbody>).

The tables in "Express behind proxies" are quite large and contain a lot embedded markdown (code blocks, lists). Unfortunately, as far as I know it is not possible to write a markdown table with lists or code blocks without using HTML for either the table or the content.

Markdown tables are automatically wrapped in .table-scroller div, but raw HTML tables have to be wrapped manually. Tables in migrating-4.mdx were simple an have been rewritten using markdown syntax.
@krzysdz
krzysdz requested a review from a team as a code ownerAugust 8, 2026 11:26
@netlify

netlifyBot commented Aug 8, 2026

Copy link
Copy Markdown

Deploy Preview for expressjscom-preview ready!

NameLink
🔨 Latest commit7414ff8
🔍 Latest deploy loghttps://app.netlify.com/projects/expressjscom-preview/deploys/6a98310df32eca0008488830
😎 Deploy Previewhttps://deploy-preview-2485--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 99 (🟢 up 2 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: 80 (no change from production)
View the detailed breakdown and full score reports
🤖 Make changesRun an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@krzysdzkrzysdz added the design Change, update, or fix for site UI (not content) label Aug 8, 2026
@krzysdz

Copy link
Copy Markdown
ContributorAuthor

One thing that I noticed while making these changes: #2221 removed a table from 5.x writing middleware docs, but left it in 4.x. The table served as an explanation of some things shown on an illustration, but the illustration has been updated to include these descriptions, so 4.x version is labelled twice.

obraz

@ShubhamOulkarShubhamOulkar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2493 fixes scrolling issues, also we discussed on rewriting to markdown tables. migrating-4 tables are in markdown, if you want then do it for tables on behind-proxies page. Removing manual addition of table-scroller is essential before merging the PR.

@krzysdzkrzysdz changed the title fix: make all tables scrollablechore: rewrite HTML tables in migrating-4.mdx to markdownSep 2, 2026
@krzysdz

Copy link
Copy Markdown
ContributorAuthor

Removed the manually added .table-scroller. Tables from behind-proxies.mdx cannot be rewritten to pure markdown.

I looked for inline HTML and other than this (cannot be removed), some other HTML that can't be removed (e.g. links wrapping Astro components) it can be found only in:

@ShubhamOulkar
ShubhamOulkar merged commit 6572271 into expressjs:mainSep 3, 2026
13 of 14 checks passed
@krzysdz
krzysdz deleted the scrollable-tables branch September 3, 2026 09:36
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

designChange, update, or fix for site UI (not content)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@krzysdz@ShubhamOulkar