Skip to content

feat: removing http internals - #1022

Merged
bjohansebas merged 2 commits into
expressjs:v2from
bjohansebas:remove-internals-of-nodejs
Apr 27, 2025
Merged

feat: removing http internals#1022
bjohansebas merged 2 commits into
expressjs:v2from
bjohansebas:remove-internals-of-nodejs

Conversation

@bjohansebas

@bjohansebasbjohansebas commented Feb 10, 2025

Copy link
Copy Markdown
Member

Although this does not provide direct support for HTTP/2, it is always good to avoid using Node.js internal APIs.

closes#908

@bjohansebas
bjohansebas changed the base branch from master to v2February 10, 2025 01:59
@bjohansebasbjohansebas added this to the 2.0.0 milestone Feb 10, 2025
@bjohansebas
bjohansebasforce-pushed the remove-internals-of-nodejs branch from 569facb to 63d966bCompareFebruary 10, 2025 02:06
@wesleytodd

Copy link
Copy Markdown
Member

Hey! I guess I am added as a reviewer on these ones? I am trying to say focused on just the core express deps, so I am going to remove myself from this one as a reviewer.

@wesleytodd
wesleytodd removed their request for review February 10, 2025 17:40
@bjohansebas
bjohansebasforce-pushed the remove-internals-of-nodejs branch from 92a938a to 42db838CompareFebruary 13, 2025 17:47
@bjohansebas
bjohansebas merged commit d0acdcf into expressjs:v2Apr 27, 2025
@bjohansebas
bjohansebas deleted the remove-internals-of-nodejs branch April 27, 2025 02:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@bjohansebas@wesleytodd