Skip to content

Add typescript defintions - #27

Closed
bilby91 wants to merge 1 commit into
expressjs:masterfrom
suttna:add-typescript-defintions
Closed

Add typescript defintions#27
bilby91 wants to merge 1 commit into
expressjs:masterfrom
suttna:add-typescript-defintions

Conversation

@bilby91

@bilby91bilby91 commented Apr 14, 2018

Copy link
Copy Markdown

No description provided.

dougwilson
dougwilson suggested changes Apr 14, 2018
View reviewed changes

@dougwilsondougwilson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much, love these contributions 👍 I just had a couple comments.

Comment threadpackage-lock.json Outdated
Comment threadtypings/index.d.ts Outdated
Comment threadpackage.json Outdated
@bilby91
bilby91force-pushed the add-typescript-defintions branch 3 times, most recently from 68b88a0 to 480c31fCompareApril 14, 2018 23:23
@dougwilson

dougwilson commented Apr 14, 2018

Copy link
Copy Markdown
Contributor

Please tell me when you're done force pushing. Every time I try to make a comment the page reload and everything I typed is lost.

@bilby91

bilby91 commented Apr 14, 2018

Copy link
Copy Markdown
Author

@dougwilson Sorry for that, it was tricky to get it working for old version of npm that don't support scoped modules. I think travis should fine now.

dougwilson
dougwilson suggested changes Apr 14, 2018
View reviewed changes

@dougwilsondougwilson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't finished my review as the force pushed kept erasing what I was typing. I have to get going now, so wanted to at least post what I was able to get saved.

Comment threadtest/test.ts Outdated
Comment threadpackage.json Outdated
@bilby91
bilby91force-pushed the add-typescript-defintions branch 3 times, most recently from 5f71207 to 856eec7CompareApril 14, 2018 23:43
dougwilson
dougwilson suggested changes Apr 15, 2018
View reviewed changes
Comment threadindex.d.ts Outdated
@bilby91
bilby91force-pushed the add-typescript-defintions branch from 856eec7 to 6de1130CompareApril 15, 2018 22:27
@bilby91

bilby91 commented Apr 15, 2018

Copy link
Copy Markdown
Author

I think it should be good now @dougwilson

@bilby91

bilby91 commented May 2, 2018

Copy link
Copy Markdown
Author

Ping @dougwilson

@dougwilson

dougwilson commented May 4, 2018

Copy link
Copy Markdown
Contributor

I'm trying to get someone on my side who knows TypeScript to review this still.

@dougwilsondougwilson self-assigned this May 4, 2018
@imjakechapman

imjakechapman commented May 31, 2019

Copy link
Copy Markdown

This has been a year, can this get merged? I'll buy someone a beer, or fly and hug you. K thanks :)

@corentingiraud

corentingiraud commented Jul 2, 2019

Copy link
Copy Markdown

Ping @dougwilson

@PabloSzx

PabloSzx commented Aug 3, 2019•
edited
Loading

Copy link
Copy Markdown

i made a fork refactored in typescript https://github.com/PabloSzx/vhost-tshttps://www.npmjs.com/package/vhost-ts but for now it only handles express types (open for PRs)

it also includes #21

@bilby91

bilby91 commented Jan 28, 2020

Copy link
Copy Markdown
Author

Ping @dougwilson

@bilby91

bilby91 commented Feb 10, 2020

Copy link
Copy Markdown
Author

I'm doing some cleanup of my PRs and I'm no longer going to work on this one.

@bilby91bilby91 closed this Feb 10, 2020
@bilby91
bilby91 deleted the add-typescript-defintions branch February 10, 2020 13:58
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@dougwilsondougwilsondougwilson requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

@dougwilsondougwilson

Labels

pr

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bilby91@dougwilson@imjakechapman@corentingiraud@PabloSzx