Samy fixes - #102
Open
sshehata wants to merge 5 commits into
Open
Conversation
wb.Formats[fNo] can return nil when the format number doesn't exist in the map, causing a nil pointer dereference when accessing .str. Add nil check consistent with XfRk.String which already handles this case. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- bof.go: guard utf16String against count==0 to prevent panic - col.go: add SST/XF bounds checks, fix NumberCol format detection bug - workbook.go: remove os.Exit(1), check binary.Read errors, add nil/bounds checks in ReadAllCells - worksheet.go: remove debug print, check binary.Read errors, validate sizes before arithmetic, guard empty slice access - comparexlsxlsx.go: add nil check for xlsRow before use - row.go: add bounds checks for string slice access - cell_range.go: fix FristColB typo to FirstColB - example_test.go: use OpenWithCloser, add nil check for sheet Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.