Skip to content

Upgraded Slidable and Kotlin min version, fixed Activity, updated example - #7

Draft
riccardo-lomazzi wants to merge 6 commits into
fabio21:masterfrom
riccardo-lomazzi:master
Draft

Upgraded Slidable and Kotlin min version, fixed Activity, updated example#7
riccardo-lomazzi wants to merge 6 commits into
fabio21:masterfrom
riccardo-lomazzi:master

Conversation

@riccardo-lomazzi

Copy link
Copy Markdown

No description provided.

@fabio21

Copy link
Copy Markdown
Owner

@copilot resolve the merge conflicts in this pull request

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the plugin and its example app to newer Flutter/Android tooling and dependency versions, aligning the project with recent Flutter SDK expectations and Android Gradle Plugin/Kotlin upgrades.

Changes:

  • Bumped package version to 1.0.8 and upgraded core Dart/Flutter dependencies (archive, flutter_slidable, share_plus), plus updated lockfiles.
  • Updated the example Android project to newer Gradle/AGP/Kotlin conventions (settings.gradle plugin management, Gradle wrapper, namespace usage, manifest cleanup).
  • Applied formatting/cleanup changes across several Flutter UI components and added VS Code launch configurations.

Reviewed changes

Copilot reviewed 23 out of 25 changed files in this pull request and generated 3 comments.

Show a summary per file
FileDescription
test/open_document_test.dartAdds a test entrypoint file (currently only commented template code).
pubspec.yamlBumps package version and upgrades direct dependencies.
pubspec.lockUpdates resolved dependency graph and SDK minimums in lockfile.
lib/my_files/my_files_screen.dartFormatting-only adjustments in widget build/app bar/error widget.
lib/my_files/components/slidable_my_file_item.dartFormatting-only adjustments to callbacks and helper signatures.
lib/my_files/components/my_files_items.dartMinor formatting/indentation cleanup.
lib/my_files/components/my_files_core.dartFormatting cleanup and line wrapping.
lib/my_files/components/header_my_folder_file.dartUpdates Color API usage (withOpacitywithValues).
example/pubspec.yamlUpgrades example dependencies (cupertino_icons/dio/permission_handler).
example/pubspec.lockUpdates example dependency resolutions and SDK minimums in lockfile.
example/android/settings.gradleMigrates to pluginManagement + plugins DSL with version properties.
example/android/gradle/wrapper/gradle-wrapper.propertiesUpdates Gradle wrapper distribution to 8.9.
example/android/gradle.propertiesUpdates JVM args and centralizes plugin version properties.
example/android/build.gradleUpdates repositories and adds namespace fallback logic for subprojects.
example/android/app/src/profile/AndroidManifest.xmlRemoves package= attribute (namespace-based manifest).
example/android/app/src/main/kotlin/com/example/example/MainActivity.ktRemoves old example MainActivity file under previous package path.
example/android/app/src/main/AndroidManifest.xmlUpdates permissions, activity declaration, and aligns with namespace-based setup.
example/android/app/src/debug/AndroidManifest.xmlRemoves package= attribute (namespace-based manifest).
example/android/app/build.gradleMigrates to plugins DSL, sets namespace/SDK levels, and updates compile options.
example/android/.gitignoreIgnores additional Android build artifacts (.cxx, .kotlin).
CHANGELOG.mdAdds 1.0.8 entry describing upgraded compatibility.
android/src/main/kotlin/com/fsconceicao/open_document/OpenDocument.ktAdjusts app label lookup logic to be more null-tolerant.
android/gradle.propertiesUpdates JVM args and centralizes AGP/Kotlin version properties.
android/build.gradleUpdates AGP/Kotlin plugin versions, sets namespace/SDK level, and adds Java/Kotlin compile options.
.vscode/launch.jsonAdds VS Code launch configurations for running the example in different modes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment threadpubspec.yaml Outdated
Comment on lines +18 to +20
archive: ^4.0.4
flutter_slidable: ^4.0.0
share_plus: ^10.1.4
Comment threadexample/pubspec.yaml
Comment on lines +18 to +20
cupertino_icons: ^1.0.6
dio: ^5.8.0
permission_handler: ^11.4.0
Comment on lines +1 to +18
void main() {
// const MethodChannel channel = MethodChannel('open_document');
//
// TestWidgetsFlutterBinding.ensureInitialized();
//
// setUp(() {
// channel.setMockMethodCallHandler((MethodCall methodCall) async {
// return '42';
// });
// });
//
// tearDown(() {
// channel.setMockMethodCallHandler(null);
// });
//
// test('getPlatformVersion', () async {
// expect(await OpenDocument.platformVersion, '42');
// });
@fabio21
fabio21 requested a review from CopilotMay 25, 2026 11:29
@fabio21
fabio21 marked this pull request as draft May 25, 2026 11:30

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 23 out of 25 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

android/build.gradle:54

  • This Gradle script appears to be syntactically invalid: dependencies { ... } is currently nested inside the android { ... } block, and the android block is not closed later in the file. Move dependencies back to the top level and ensure all {} are properly closed.
dependencies {
implementation(platform("org.jetbrains.kotlin:kotlin-bom:1.8.22"))
// implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"
}

Comment on lines 4 to +7
android.enableJetifier=true
# Plugin Versions
androidToolsBuildGradleVersion=8.5.0
kotlinVersion=2.0.20 No newline at end of file
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@riccardo-lomazzi@fabio21@rlomazzimitric