Skip to content

Update for fabric3.0 - #46

Open
LecrisUT wants to merge 8 commits into
fabric:masterfrom
LecrisUT:fabric3
Open

Update for fabric3.0#46
LecrisUT wants to merge 8 commits into
fabric:masterfrom
LecrisUT:fabric3

Conversation

@LecrisUT

@LecrisUTLecrisUT commented Mar 15, 2023•
edited
Loading

Copy link
Copy Markdown
  • Resolve issues for fabric 3.0
  • Pep621 modernization
  • Changed .format to fstrings for more readability

Fixes: #41
Depends-on: #47

@LecrisUT
LecrisUT marked this pull request as draft March 15, 2023 13:41
@bpluly

bpluly commented Mar 24, 2023

Copy link
Copy Markdown

Just as commentary, patching with this I was able to install the library and everything seems fine, I don't have all the test tools and haven't addressed that. I did wonder why setup.py was removed as it should still install with a toml file. Unless this is part of the work in progress it's worth calling it out in the PR.

@bplulybpluly mentioned this pull request Mar 24, 2023
Open
@LecrisUT

LecrisUT commented Mar 24, 2023

Copy link
Copy Markdown
Author

The change from setup.py to pyproject.toml is just implementing PEP621 since most projects are/should be migrating to it. That part is finished. For this PR, the only reason it is in draft is because I don't feel confident without getting the pytest running. The test method implemented also seems to contradict the recommended approach using MockContext. If you have any hints on how to get the tests I can translate them over.

@LecrisUT
LecrisUT marked this pull request as ready for review March 24, 2023 16:07
@LecrisUT

LecrisUT commented Mar 24, 2023•
edited
Loading

Copy link
Copy Markdown
Author

Ok, the tests are running again. I was missing a dependency. I'll try to see if I can fix the test failures. Failed docs are related to docstring, got no idea how to fix those.

@bitprophetbitprophet mentioned this pull request Mar 24, 2023
Closed
@bitprophet

bitprophet commented Mar 24, 2023

Copy link
Copy Markdown
Member

Thanks for poking at this. I don't have a lot of time to dig right now but hopefully sometime soon-ish.

I did notice you set the dep to fabric>=3 - the backwards incompat changes in 3.x were quite minor (the big one was just dropping Py<3.6 support, which is handle-able by users' pips) so it's not clear to me what exactly broke here under 3.x. I think it's more likely the breakage was on 2.x (which was a total rewrite) and you should be able to set the pyproject field to >=2 instead?

@bitprophetbitprophet added this to the Next big release milestone Mar 24, 2023
LecrisUT
LecrisUT commented Mar 24, 2023
View reviewed changes

@LecrisUTLecrisUT left a comment •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bitprophet I've highlighted the main changes. Others were stylistic changes. And indeed, at least from the pytest, there didn't seem to be anything drastically changed, the only one seems to be with parsing the docstring, if you can assign someone to take a look at that, that would be wonderful

Comment threadtasks.py
@@ -1,6 +1,6 @@
from importlib import import_module

from invocations import docs, travis

@LecrisUTLecrisUTMar 24, 2023

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invocations.travis was dropped.

Comment threadsrc/patchwork/util.py Outdated
Comment threadsrc/patchwork/transfers.py
@@ -2,8 +2,6 @@
File transfer functionality above and beyond basic ``put``/``get``.
"""

from invoke.vendor import six

@LecrisUTLecrisUTMar 24, 2023

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

invoke does not bundle six, moved to str

Comment threadpyproject.toml Outdated
@LecrisUT
Remove travis
ea20f3b
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
LecrisUTforce-pushed the fabric3 branch 3 times, most recently from 2800b11 to 23c9abaCompareApril 19, 2023 08:08
@LecrisUT
Add simple gitignore
4462c01
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
Add basic pre-commit
6399af1
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
Add basic GitHub Action
9b235c3
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
LecrisUTforce-pushed the fabric3 branch 2 times, most recently from 0920324 to 8cfc5c3CompareApril 19, 2023 08:36
@LecrisUT
Update for fabric3.0
e6c5a2c
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
Fix munge_docstring
c3c286f
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
Update GitHub action
38db2d2
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT
Add pytest for Fabric2.x
a252ad3
Signed-off-by: Cristian Le <cristian.le@mpsd.mpg.de>
@LecrisUT

LecrisUT commented Apr 19, 2023

Copy link
Copy Markdown
Author

@bitprophet I hope the CIs here help. Please check the runs on my fork until the github action is enabled.

Are you ok with updating the minimum python requirement to 3.7? 3.6 does not support PEP621

@JoshYuJump

JoshYuJump commented Dec 29, 2023

Copy link
Copy Markdown

@bitprophet I hope the CIs here help. Please check the runs on my fork until the github action is enabled.

Are you ok with updating the minimum python requirement to 3.7? 3.6 does not support PEP621

Python 3.7 has reached EOF, may by minimum python requirement should be 3.8

@SamuelMarks

SamuelMarks commented Jan 1, 2024

Copy link
Copy Markdown

I'm supporting 2.7, 3.5, 3.6, 3.7, 3.8, 3.9, 3.10, 3.11, 3.12 with Fabric and Patchwork. Would be great if this could be merged without breaking support for 3.5+ (so I can easily remain on Fabric 2.7.1 on python_version<'3.5' and newer versions later)

@LecrisUT

LecrisUT commented Jan 2, 2024

Copy link
Copy Markdown
Author

@SamuelMarks If you want, you can run these tests on your fork with the minimum Python version you wish, and report back the patches needed to make it compatible. I don't remember if I checked the minimum requirements below those versions

@SamuelMarksSamuelMarks mentioned this pull request Apr 2, 2024
Draft
@SamuelMarks

SamuelMarks commented Apr 2, 2024

Copy link
Copy Markdown

@LecrisUT Only just got the chance. It should now support Python 2.7 (added the older setup.py which is compatible with older versions)

@lakinweckerlakinwecker mentioned this pull request Aug 4, 2024
Open
@geoffrey-eisenbarth

geoffrey-eisenbarth commented Dec 13, 2024

Copy link
Copy Markdown

@bitprophet Any movement on this? Thanks :)

@hockeymikey

hockeymikey commented Jun 20, 2025

Copy link
Copy Markdown

Why is this still not merged?

@SamuelMarks

SamuelMarks commented Jun 30, 2025

Copy link
Copy Markdown

It's taken so long to merge that I rewrote my Python [Libcloud+Fabric] open-source configuration-driven deployment system in Go… then in Rust… then in /bin/sh

(see my GitHub)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Next big release

Development

Successfully merging this pull request may close these issues.

cannot import name 'six' from 'invoke.vendor'

7 participants

@LecrisUT@bpluly@bitprophet@JoshYuJump@SamuelMarks@geoffrey-eisenbarth@hockeymikey